Files.app: Add NewMetadataProvider class.

Files.app: Add NewMetadataProvider class.

The class will be used as the base class of all metadata provider.  The class has abstrct
getImpl method and sub-class of the class should inherit the function. The class
also contains MetadataProviderCache that is a sub-class of MetadataCacheSet, and
caches the result of getImpl method.

BUG=410766
TEST=FileManagerJsTest.NewMetadataProvider

Committed: https://crrev.com/5eef262146d69b3773e69fa6f886cf869b7adb24
Cr-Commit-Position: refs/heads/master@{#314279}

[hirono, 2015-02-03 03:51:18]

hirono@chromium.org changed reviewers:
+ yawano@chromium.org

[hirono, 2015-02-03 03:51:18]

Sorry for series of huge patches...
PTAL, thanks!

[yawano, 2015-02-03 04:24:28]

lgtm with nits.

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
File
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js
(right):

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js:140:
this.reject_ = reject;
nit: When is reject callback called?

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js:144:
* @param {number} requestId
nit: Please provide doc comment for public methods.

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js:171:
* @type {number}
nit: @private

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js:179:
* @return {number}
nit: Please provide doc comment for public methods.

[hirono, 2015-02-03 05:29:00]

Thanks!

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
File
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js
(right):

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js:140:
this.reject_ = reject;
On 2015/02/03 04:24:28, yawano wrote:
> nit: When is reject callback called?

Calling this is a part of TODO at #82.
Updated the TODO comment.

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js:144:
* @param {number} requestId
On 2015/02/03 04:24:28, yawano wrote:
> nit: Please provide doc comment for public methods.

Done.

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js:171:
* @type {number}
On 2015/02/03 04:24:28, yawano wrote:
> nit: @private

Done.

https://codereview.chromium.org/894283002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js:179:
* @return {number}
On 2015/02/03 04:24:28, yawano wrote:
> nit: Please provide doc comment for public methods.

Done.

[hirono, 2015-02-03 05:29:04]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2015-02-03 05:29:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/894283002/40001

[commit-bot: I haz the power, 2015-02-03 06:36:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-03 06:39:02]

Patchset 3 (id:??) landed as
https://crrev.com/5eef262146d69b3773e69fa6f886cf869b7adb24
Cr-Commit-Position: refs/heads/master@{#314279}