Add a proper shadow to the experimental app list search box.

ui/app_list/views/app_list_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_view.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 91 matching lines @@
     paint.setColor(SK_ColorWHITE);
     canvas->DrawRoundRect(GetContentsBounds(), corner_radius_, paint);
   }
 
  private:
   const int corner_radius_;
 
   DISALLOW_COPY_AND_ASSIGN(AppListOverlayView);
 };
 
+// An event targeter for the search box widget which will ignore events that
+// are on the search box's shadow.
+class SearchBoxWindowTargeter : public wm::MaskedWindowTargeter {

[tapted, 2015/02/03 23:56:31]

this needs to be in USE_AURA as well. And wm::MaskedWindowTargeter should have a
#include for iwyu  (also in USE_AURA) (it's currently pulled in via
bubble_window_targeter)

[calamity, 2015/02/04 03:37:01]

Done.

+ public:
+  SearchBoxWindowTargeter(aura::Window* window, views::View* content_view)
+      : wm::MaskedWindowTargeter(window), content_view_(content_view) {}

[tapted, 2015/02/03 23:56:31]

nit: can you pass content_view->GetWidget()->GetNativeWindow() to the superclass
constructor here? That would be consistent with what BubbleWindowTargeter does

content_view_->GetContentsBounds() is probably a constant too.... you could have
a gfx::Rect member instead of a raw pointer, but that feels more fragile, so
ignore this second bit.

[calamity, 2015/02/04 03:37:01]

Done.
Actually it isn't. The search box animates, changing its contents bounds
constantly.

+  ~SearchBoxWindowTargeter() override {}
+
+ private:
+  // wm::MaskedWindowTargeter:
+  bool GetHitTestMask(aura::Window* window, gfx::Path* mask) const override {
+    mask->addRect(gfx::RectToSkRect(content_view_->ConvertRectToWidget(

[tapted, 2015/02/03 23:56:31]

Q: Is the ConvertRectToWidget bit needed (I only ask because
BubbleWindowTargeter doesn't use it and I'm too lazy to figure out which is more
correct).

[calamity, 2015/02/04 03:37:01]

Yeah, it can be removed.

+        content_view_->GetContentsBounds())));
+    return true;
+  }
+
+  views::View* content_view_;
+
+  DISALLOW_COPY_AND_ASSIGN(SearchBoxWindowTargeter);
+};
+
 }  // namespace
 
 // An animation observer to hide the view at the end of the animation.
 class HideViewAnimationObserver : public ui::ImplicitAnimationObserver {
  public:
   HideViewAnimationObserver()
       : frame_(NULL),
         target_(NULL) {
   }
 
@@ skipping 297 matching lines @@
   search_box_widget_params.opacity =
       views::Widget::InitParams::TRANSLUCENT_WINDOW;
 
   // Create a widget for the SearchBoxView to live in. This allows the
   // SearchBoxView to be on top of the custom launcher page's WebContents
   // (otherwise the search box events will be captured by the WebContents).
   search_box_widget_ = new views::Widget;
   search_box_widget_->Init(search_box_widget_params);
   search_box_widget_->SetContentsView(search_box_view_);
 
+#if defined(USE_AURA)

[Matt Giuca, 2015/02/03 07:29:23]

Adding Trent to get opinion about this (as the resident Views-but-not-Aura
expert).

+  // Mouse events on the search box shadow should not be captured.
+  aura::Window* window = search_box_widget_->GetNativeWindow();
+  window->SetEventTargeter(scoped_ptr<ui::EventTargeter>(
+      new SearchBoxWindowTargeter(window, search_box_view_)));
+#endif
+
   app_list_main_view_->contents_view()->Layout();
 }
 
 void AppListView::InitAsBubbleInternal(gfx::NativeView parent,
                                        int initial_apps_page,
                                        views::BubbleBorder::Arrow arrow,
                                        bool border_accepts_events,
                                        const gfx::Vector2d& anchor_offset) {
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/431326 is fixed.
   tracked_objects::ScopedTracker tracking_profile1(
@@ skipping 287 matching lines @@
 
   if (will_appear) {
     speech_view_->SetVisible(true);
   } else {
     app_list_main_view_->SetVisible(true);
     search_box_view_->search_box()->RequestFocus();
   }
 }
 
 }  // namespace app_list