Source/core/html/canvas/WebGL2RenderingContext.idl - Issue 894143002: Adding Blink bindings for WebGL 2

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/canvas/WebGL2RenderingContext.idl

Issue 894143002: Adding Blink bindings for WebGL 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed @kbr's feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 RuntimeEnabled=UnsafeES3APIs,

	7 DoNotCheckConstants,

	8 TypeChecking=Interface,

	9 WillBeGarbageCollected,

	10 ] interface WebGL2RenderingContext { };

	11 WebGL2RenderingContext implements WebGLRenderingContextBase;
	yunchao 2015/02/09 08:19:45 WebGL2RenderingContext implements/inherts WebGL2Re WebGL2RenderingContext implements/inherts WebGL2RenderingContextBase, and WebGL2RenderingContextBase implements/inherits WebGLRenderingContextBase. So this line is unnecessary. Unfortunately, I came across the same problem that WebGL2RenderingContext can not binding APIs those defined in WebGLRenderingContextBase. Personally, I think there should be a TODO to revise Blink binding code to binding those APIs inherit from its grandparents or older ancestors.
	12 WebGL2RenderingContext implements WebGL2RenderingContextBase;

OLD	NEW