Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 89413002: linux aura: Support touch events. (Closed)

Created:
7 years ago by sadrul
Modified:
7 years ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

linux aura: Support touch events. Update coalescing code to make sure touch-update events are also coalesced. BUG=none R=dongseong.hwang@intel.com, erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238745

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M ui/base/x/x11_util.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 2 3 4 2 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dshwang
Thank you for this CL. non-owner's lgtm Could I continue my question from https://chromiumcodereview.appspot.com/14582028/#msg11 ? ...
7 years ago (2013-11-27 09:14:28 UTC) #1
sadrul
On 2013/11/27 09:14:28, dshwang wrote: > Thank you for this CL. non-owner's lgtm > > ...
7 years ago (2013-11-28 17:29:12 UTC) #2
sadrul
+erg@ for review.
7 years ago (2013-11-28 17:29:43 UTC) #3
dshwang
https://codereview.chromium.org/89413002/diff/60001/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc File ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc (right): https://codereview.chromium.org/89413002/diff/60001/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc#newcode1118 ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc:1118: event->type() == ui::ET_MOUSE_PRESSED) { s/ET_MOUSE_PRESSED/ET_TOUCH_PRESSED/ ? why DispatchMouseEvent() does ...
7 years ago (2013-12-04 17:37:27 UTC) #4
sadrul
https://codereview.chromium.org/89413002/diff/60001/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc File ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc (right): https://codereview.chromium.org/89413002/diff/60001/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc#newcode1118 ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc:1118: event->type() == ui::ET_MOUSE_PRESSED) { On 2013/12/04 17:37:27, dshwang wrote: ...
7 years ago (2013-12-04 17:57:28 UTC) #5
Elliot Glaysher
lgtm
7 years ago (2013-12-04 18:36:24 UTC) #6
sadrul
Committed patchset #5 manually as r238745 (presubmit successful).
7 years ago (2013-12-04 20:11:02 UTC) #7
dshwang
7 years ago (2013-12-05 09:15:58 UTC) #8
Message was sent while issue was closed.
Thank you for supporting touch event in linux aura. :)

Powered by Google App Engine
This is Rietveld 408576698