Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 894123002: MIPS: Skip mozilla/js1_5/extensions/regress-355497 in simulator. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Skip mozilla/js1_5/extensions/regress-355497 in simulator. BUG= Committed: https://crrev.com/7cb12037d30b255090b0ff0f01d7221cacc86c1a Cr-Commit-Position: refs/heads/master@{#26392}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Leave mips64el. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M test/mozilla/mozilla.status View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-02 18:41:48 UTC) #2
paul.l...
https://codereview.chromium.org/894123002/diff/1/test/mozilla/mozilla.status File test/mozilla/mozilla.status (right): https://codereview.chromium.org/894123002/diff/1/test/mozilla/mozilla.status#newcode881 test/mozilla/mozilla.status:881: 'js1_5/extensions/regress-355497': [SKIP], I'd rather not change mips64 test, unless ...
5 years, 10 months ago (2015-02-02 19:07:43 UTC) #3
balazs.kilvady
https://codereview.chromium.org/894123002/diff/1/test/mozilla/mozilla.status File test/mozilla/mozilla.status (right): https://codereview.chromium.org/894123002/diff/1/test/mozilla/mozilla.status#newcode881 test/mozilla/mozilla.status:881: 'js1_5/extensions/regress-355497': [SKIP], On 2015/02/02 19:07:43, paul.l... wrote: > I'd ...
5 years, 10 months ago (2015-02-02 19:35:05 UTC) #4
paul.l...
LGTM. We do need v8 team review for this. Benedikt, we considered adding FLAG_sim_stack_size to ...
5 years, 10 months ago (2015-02-02 19:47:21 UTC) #5
Benedikt Meurer
I'm fine with that.
5 years, 10 months ago (2015-02-03 06:01:03 UTC) #7
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-03 06:01:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894123002/20001
5 years, 10 months ago (2015-02-03 06:01:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 06:31:46 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 06:32:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cb12037d30b255090b0ff0f01d7221cacc86c1a
Cr-Commit-Position: refs/heads/master@{#26392}

Powered by Google App Engine
This is Rietveld 408576698