gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 894093004: The Shader class now support deferred shader compiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 894093004: The Shader class now support deferred shader compiling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made RequestCompile() mandatory when using shader compiler Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index f37c61a4808d9832879583c2321d05c2fdac9602..7c9e803df3676293b47aa081c56f8d7b58cc7cab 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -7086,6 +7086,10 @@ void GLES2DecoderImpl::DoCompileShader(GLuint client_id) {

vertex_translator_.get() : fragment_translator_.get();

}

+ shader->RequestCompile();

+ // TODO(dyen): Currently we compile immediately when glCompileShader is

+ // requested. Eventually this should be deffered to the linker stage.

Ken Russell (switch to Gerrit) 2015/02/04 22:59:59 typo: deferred

shader->DoCompile(

translator,

feature_info_->feature_flags().angle_translated_shader_source ?

« no previous file with comments | « no previous file | gpu/command_buffer/service/memory_program_cache.cc » ('j') | gpu/command_buffer/service/shader_manager.cc » ('J')