pkg/analyzer/lib/src/generated/resolver.dart - Issue 894063004: Fix return type checking for generator functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 894063004: Fix return type checking for generator functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 01e10a4277957e8d550e94bd33cc8c926e97b4dd..23b984f7c11cbaca258c867ae2542913f88d9e8c 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -582,6 +582,10 @@ class BestPracticesVerifier extends RecursiveAstVisitor<Object> {

if (body is! BlockFunctionBody) {

return false;

}

+ // Generators are never required to have a return statement.

+ if (body.isGenerator) {

+ return false;

+ }

// Check that the type is resolvable, and is not "void"

DartType returnTypeType = returnType.type;

if (returnTypeType == null || returnTypeType.isVoid) {