Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 894053002: MIPS64: Megamorphic KeyedLoadIC needs special handling for vector ics. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Megamorphic KeyedLoadIC needs special handling for vector ics. Port 16843e239d95f5e8eaaa06d2a0a6e371298fe11f Original commit message: When --vector-ics is true, we still tail-call to the hand-written megamorphic KeyedLoadIC (formerly "generic"). Now that this code uses the megamorphic cache, it needs to deal properly with the vector and slot registers. Achieve this with a sentinel vectors/slot combo. BUG= Committed: https://crrev.com/6019cbf9dfe5893283b9df86613cf1afddc7e344 Cr-Commit-Position: refs/heads/master@{#26384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/ic/mips64/ic-mips64.cc View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-02 16:56:51 UTC) #2
dusmil.imgtec
lgtm.
5 years, 10 months ago (2015-02-02 16:59:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894053002/1
5 years, 10 months ago (2015-02-02 17:20:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 17:50:17 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 17:50:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6019cbf9dfe5893283b9df86613cf1afddc7e344
Cr-Commit-Position: refs/heads/master@{#26384}

Powered by Google App Engine
This is Rietveld 408576698