SearchSuggestionParser: Use a StringPiece instead of modifying a string.

SearchSuggestionParser: JSON deserializer now accepts a StringPiece.

Internally, it slices the StringPiece instead of erasing pieces of the
string, so we have 0 copies of these JSON strings. This is possible now
that JSONStringValueSerializer takes a StringPiece.

BUG=455068
Committed: https://crrev.com/b04f6a3a5f2f4896bdd8df7c60d3cc6d7a4714fd
Cr-Commit-Position: refs/heads/master@{#314936}

[Matt Giuca, 2015-02-05 05:30:36]

mgiuca@chromium.org changed reviewers:
+ pkasting@chromium.org

[Matt Giuca, 2015-02-05 05:30:36]

I just landed https://codereview.chromium.org/895913004/ so now this is possible
(previously it would have required us to copy into a string before passing to
JSONStringValueSerializer). Now we can do it with 0 copies.

[Peter Kasting, 2015-02-05 09:20:36]

LGTM

https://codereview.chromium.org/894033006/diff/20001/components/omnibox/searc...
File components/omnibox/search_suggestion_parser.cc (right):

https://codereview.chromium.org/894033006/diff/20001/components/omnibox/searc...
components/omnibox/search_suggestion_parser.cc:352: if (response_start_index >
0)
Nit: This conditional could just be removed and the call done unconditionally.

[Matt Giuca, 2015-02-06 00:26:54]

New patchsets have been uploaded after l-g-t-m from pkasting@chromium.org

[Matt Giuca, 2015-02-06 00:30:02]

https://codereview.chromium.org/894033006/diff/20001/components/omnibox/searc...
File components/omnibox/search_suggestion_parser.cc (right):

https://codereview.chromium.org/894033006/diff/20001/components/omnibox/searc...
components/omnibox/search_suggestion_parser.cc:352: if (response_start_index >
0)
On 2015/02/05 09:20:36, Peter Kasting wrote:
> Nit: This conditional could just be removed and the call done unconditionally.

Done.

[Matt Giuca, 2015-02-06 00:30:06]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-02-06 00:30:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/894033006/40001

[commit-bot: I haz the power, 2015-02-06 01:15:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 01:16:38]

Patchset 3 (id:??) landed as
https://crrev.com/b04f6a3a5f2f4896bdd8df7c60d3cc6d7a4714fd
Cr-Commit-Position: refs/heads/master@{#314936}