Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 894003005: Revert "Load web contents after tab is created." (Closed)

Created:
5 years, 10 months ago by Maria
Modified:
5 years, 10 months ago
Reviewers:
Ted C, jbudorick, sky
CC:
chromium-reviews, darin-cc_chromium.org, klundberg+watch_chromium.org, jam, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Load web contents after tab is created." This reverts commit 4c55f398def3214369aefa9f2f2e8f5940d3799d. BUG=432562 TBR=tedchoc@chromium.org,jbudorick@chromium.org,sky@chromium.org Committed: https://crrev.com/6b96dd532af164a73f2aac757bafff58211aca2c Cr-Commit-Position: refs/heads/master@{#314469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -81 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/PendingDocumentData.java View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 2 chunks +11 lines, -14 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894003005/1
5 years, 10 months ago (2015-02-04 00:08:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 01:57:04 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 01:58:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b96dd532af164a73f2aac757bafff58211aca2c
Cr-Commit-Position: refs/heads/master@{#314469}

Powered by Google App Engine
This is Rietveld 408576698