Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 894003003: tools: fix postmortem generator

Created:
5 years, 10 months ago by indutny
Modified:
5 years, 10 months ago
Reviewers:
mvstanton, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

tools: fix postmortem generator BUG= R=danno

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M src/globals.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gen-postmortem-metadata.py View 4 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
indutny
5 years, 10 months ago (2015-02-02 13:28:25 UTC) #1
danno
Hi Fedor, Thanks for the patch. Could you elaborate why this change is necessary? Danno
5 years, 10 months ago (2015-02-02 13:48:22 UTC) #3
indutny
Hello Daniel, Sure. Here is a build errors without this patch: /Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:6:10: fatal error: 'v8.h' ...
5 years, 10 months ago (2015-02-02 13:56:29 UTC) #4
indutny
Hello Daniel, Sure. Here is a build errors without this patch: /Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:6:10: fatal error: 'v8.h' ...
5 years, 10 months ago (2015-02-02 13:56:29 UTC) #5
danno
lgtm
5 years, 10 months ago (2015-02-02 15:31:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894003003/1
5 years, 10 months ago (2015-02-02 15:31:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/306)
5 years, 10 months ago (2015-02-02 15:33:35 UTC) #10
danno
Please resubmit with your "fedor@indutny.com" address, that's the one we have on file for your ...
5 years, 10 months ago (2015-02-02 15:37:32 UTC) #11
indutny
On 2015/02/02 15:37:32, danno wrote: > Please resubmit with your mailto:"fedor@indutny.com" address, that's the one ...
5 years, 10 months ago (2015-02-02 16:39:47 UTC) #12
indutny
5 years, 10 months ago (2015-02-02 16:43:37 UTC) #13

Powered by Google App Engine
This is Rietveld 408576698