Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 893993007: Protect against uninitialized lexical variables at top-level. (Closed)

Created:
5 years, 10 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Protect against uninitialized lexical variables at top-level. R=rossberg@chromium.org BUG=chromium:452510 LOG=Y Committed: https://crrev.com/8241147f465bf7bea1291cc66043692c53f17b27 Cr-Commit-Position: refs/heads/master@{#26466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M src/hydrogen.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M test/cctest/test-decls.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dmitry Lomov (no reviews)
PTAL. cq if looks good to you as is.
5 years, 10 months ago (2015-02-05 12:44:47 UTC) #1
rossberg
lgtm
5 years, 10 months ago (2015-02-05 14:11:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893993007/1
5 years, 10 months ago (2015-02-05 14:11:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 16:35:18 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 16:35:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8241147f465bf7bea1291cc66043692c53f17b27
Cr-Commit-Position: refs/heads/master@{#26466}

Powered by Google App Engine
This is Rietveld 408576698