Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 893993006: Enumerate all display adapters to detect AMD switchable graphics. (Closed)

Created:
5 years, 10 months ago by jbauman
Modified:
5 years, 10 months ago
Reviewers:
Zhenyao Mo, brucedawson
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enumerate all display adapters to detect AMD switchable graphics. Keying off of the driver manufacturer name doesn't work on some systems, so use SetupAPI to enumerate all installed display adapters to check if both an AMD and Intel display adapter are installed. BUG=455046, 451420 NOPRESUBMIT=true Committed: https://crrev.com/dd5bf63e4a1d177137a9c6c641bbc6c4782ef202 Cr-Commit-Position: refs/heads/master@{#314923}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -39 lines) Patch
M gpu/config/gpu_info_collector_win.cc View 1 6 chunks +115 lines, -39 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
jbauman
5 years, 10 months ago (2015-02-05 22:45:41 UTC) #2
Zhenyao Mo
LGTM Note now you scan through all devices, you need to modify the internal GetAMDVideocardInfo() ...
5 years, 10 months ago (2015-02-05 23:04:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893993006/20001
5 years, 10 months ago (2015-02-05 23:18:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 00:21:25 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dd5bf63e4a1d177137a9c6c641bbc6c4782ef202 Cr-Commit-Position: refs/heads/master@{#314923}
5 years, 10 months ago (2015-02-06 00:22:22 UTC) #8
brucedawson
5 years, 10 months ago (2015-02-09 18:25:41 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/893993006/diff/20001/gpu/config/gpu_info_coll...
File gpu/config/gpu_info_collector_win.cc (right):

https://codereview.chromium.org/893993006/diff/20001/gpu/config/gpu_info_coll...
gpu/config/gpu_info_collector_win.cc:487: uint32 vendor_id = 0, device_id = 0;
This variable declaration of device_id shadows the device_id wstring variable
that is declared at an outer scoped, and used just three lines earlier. This is
not illegal or undefined, but it is confusing. One of the variable names should
be changed to avoid this confusion.

Powered by Google App Engine
This is Rietveld 408576698