build/toolchain/nacl/BUILD.gn - Issue 893993005: NaCl-side GN changes to enable NaCl in Linux x64 Chrome builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/nacl/BUILD.gn

Issue 893993005: NaCl-side GN changes to enable NaCl in Linux x64 Chrome builds. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@nacl_trusted_3

Patch Set: patch for review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/nacl/BUILD.gn

diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn

index 10a0651deb90f8d9231fb81ac9b82c09d12195ff..a52b0289f55d06aed5958cc0528ac79b7f00d7b2 100644

--- a/build/toolchain/nacl/BUILD.gn

+++ b/build/toolchain/nacl/BUILD.gn

@@ -147,7 +147,7 @@ nacl_toolchain("irt_x64") {

ar = toolprefix + "ar"

readelf = toolprefix + "readelf"

# Link with cc to avoid including any C++ libs.

- ld = "${python_path} ${link_irt} --tls-edit=tls_edit --link-cmd=${cc} --readelf-cmd=${readelf}"

+ ld = "${python_path} ${link_irt} --tls-edit=tls_edit --link-cmd=${cxx} --readelf-cmd=${readelf}"

Dirk Pranke 2015/02/04 23:26:51 This change is needed because Chrome's implementat

Roland McGrath 2015/02/04 23:31:36 Put comments in the code, not in the review. The

Dirk Pranke 2015/02/04 23:35:35 Ah, good point. Will do.

# TODO(ncbray): depend on link script

deps = [

« no previous file with comments | « no previous file | src/shared/serialization/BUILD.gn » ('j') | src/trusted/service_runtime/BUILD.gn » ('J')