Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: build/toolchain/nacl/BUILD.gn

Issue 893993005: NaCl-side GN changes to enable NaCl in Linux x64 Chrome builds. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@nacl_trusted_3
Patch Set: update w/ review feedback from ncbray Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/shared/serialization/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The Native Client Authors. All rights reserved. 1 # Copyright (c) 2014 The Native Client Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//native_client/build/config/sysroot.gni") 5 import("//native_client/build/config/sysroot.gni")
6 import("//native_client/build/toolchain/nacl_toolchain.gni") 6 import("//native_client/build/toolchain/nacl_toolchain.gni")
7 7
8 declare_args() { 8 declare_args() {
9 nacl_toolchain_dir = rebase_path("//native_client/toolchain", root_build_dir) 9 nacl_toolchain_dir = rebase_path("//native_client/toolchain", root_build_dir)
10 } 10 }
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 toolchain_package = "pnacl_newlib" 119 toolchain_package = "pnacl_newlib"
120 toolchain_revision = pnacl_newlib_rev 120 toolchain_revision = pnacl_newlib_rev
121 toolchain_cpu_arch = "x86" 121 toolchain_cpu_arch = "x86"
122 toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/i686-nacl-" 122 toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/i686-nacl-"
123 is_clang = true 123 is_clang = true
124 124
125 cc = toolprefix + "clang" 125 cc = toolprefix + "clang"
126 cxx = toolprefix + "clang++" 126 cxx = toolprefix + "clang++"
127 ar = toolprefix + "ar" 127 ar = toolprefix + "ar"
128 readelf = toolprefix + "readelf" 128 readelf = toolprefix + "readelf"
129 # Link with cc to avoid including any C++ libs. 129 # Some IRT implementations (notably, Chromium's) contain C++ code,
130 ld = "${python_path} ${link_irt} --tls-edit=tls_edit --link-cmd=${cc} --readel f-cmd=${readelf}" 130 # so we need to link w/ the C++ linker.
131 ld = "${python_path} ${link_irt} --tls-edit=tls_edit --link-cmd=${cxx} --reade lf-cmd=${readelf}"
131 132
132 # TODO(ncbray): depend on link script 133 # TODO(ncbray): depend on link script
133 deps = [ 134 deps = [
134 "//native_client/src/tools/tls_edit:tls_edit($host_toolchain)", 135 "//native_client/src/tools/tls_edit:tls_edit($host_toolchain)",
135 ] 136 ]
136 } 137 }
137 138
138 nacl_toolchain("irt_x64") { 139 nacl_toolchain("irt_x64") {
139 toolchain_package = "pnacl_newlib" 140 toolchain_package = "pnacl_newlib"
140 toolchain_revision = pnacl_newlib_rev 141 toolchain_revision = pnacl_newlib_rev
141 toolchain_cpu_arch = "x64" 142 toolchain_cpu_arch = "x64"
142 toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/x86_64-nacl-" 143 toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/x86_64-nacl-"
143 is_clang = true 144 is_clang = true
144 145
145 cc = toolprefix + "clang" 146 cc = toolprefix + "clang"
146 cxx = toolprefix + "clang++" 147 cxx = toolprefix + "clang++"
147 ar = toolprefix + "ar" 148 ar = toolprefix + "ar"
148 readelf = toolprefix + "readelf" 149 readelf = toolprefix + "readelf"
149 # Link with cc to avoid including any C++ libs. 150 # Some IRT implementations (notably, Chromium's) contain C++ code,
150 ld = "${python_path} ${link_irt} --tls-edit=tls_edit --link-cmd=${cc} --readel f-cmd=${readelf}" 151 # so we need to link w/ the C++ linker.
152 ld = "${python_path} ${link_irt} --tls-edit=tls_edit --link-cmd=${cxx} --reade lf-cmd=${readelf}"
151 153
152 # TODO(ncbray): depend on link script 154 # TODO(ncbray): depend on link script
153 deps = [ 155 deps = [
154 "//native_client/src/tools/tls_edit:tls_edit($host_toolchain)", 156 "//native_client/src/tools/tls_edit:tls_edit($host_toolchain)",
155 ] 157 ]
156 } 158 }
157 159
158 # Uses newlib to match the Chrome build. 160 # Uses newlib to match the Chrome build.
159 nacl_toolchain("irt_arm") { 161 nacl_toolchain("irt_arm") {
160 toolchain_package = "nacl_arm_newlib" 162 toolchain_package = "nacl_arm_newlib"
161 toolchain_revision = nacl_arm_newlib_rev 163 toolchain_revision = nacl_arm_newlib_rev
162 toolchain_cpu_arch = "arm" 164 toolchain_cpu_arch = "arm"
163 toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/arm-nacl-" 165 toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/arm-nacl-"
164 166
165 cc = toolprefix + "gcc" 167 cc = toolprefix + "gcc"
166 cxx = toolprefix + "g++" 168 cxx = toolprefix + "g++"
167 ar = toolprefix + "ar" 169 ar = toolprefix + "ar"
168 readelf = toolprefix + "readelf" 170 readelf = toolprefix + "readelf"
169 # Link with cc to avoid including any C++ libs. 171 # Some IRT implementations (notably, Chromium's) contain C++ code,
170 ld = "${python_path} ${link_irt} --tls-edit=tls_edit --link-cmd=${cc} --readel f-cmd=${readelf}" 172 # so we need to link w/ the C++ linker.
173 ld = "${python_path} ${link_irt} --tls-edit=tls_edit --link-cmd=${cxx} --reade lf-cmd=${readelf}"
171 174
172 # TODO(ncbray): depend on link script 175 # TODO(ncbray): depend on link script
173 deps = [ 176 deps = [
174 "//native_client/src/tools/tls_edit:tls_edit($host_toolchain)", 177 "//native_client/src/tools/tls_edit:tls_edit($host_toolchain)",
175 ] 178 ]
176 } 179 }
OLDNEW
« no previous file with comments | « no previous file | src/shared/serialization/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698