src/shared/serialization/BUILD.gn - Issue 893993005: NaCl-side GN changes to enable NaCl in Linux x64 Chrome builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/shared/serialization/BUILD.gn

Issue 893993005: NaCl-side GN changes to enable NaCl in Linux x64 Chrome builds. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@nacl_trusted_3

Patch Set: update w/ review feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2014 The Native ClientAuthors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//components/nacl/nacl_defines.gni")
	Nick Bray (chromium) 2015/02/05 22:52:55 Is there a //components directory in the NaCl repo Is there a //components directory in the NaCl repo? Dirk Pranke 2015/02/05 22:55:47 Whoops. No, of course not. I meant to clean this u Show quoted text On 2015/02/05 22:52:55, Nick Bray (chromium) wrote: > Is there a //components directory in the NaCl repo? Whoops. No, of course not. I meant to clean this up but forgot. Will do.
	6

	7 source_set("serialization") {

	8 defines = nacl_defines
	Nick Bray (chromium) 2015/02/05 22:52:55 I believe the correct way to get these defines is I believe the correct way to get these defines is to depend on "//native_client/build/config/nacl:nacl_base" In general, every target in the NaCl repo should depend on this target. (Including the other ones you added.) Dirk Pranke 2015/02/05 22:55:47 Will do. Show quoted text On 2015/02/05 22:52:55, Nick Bray (chromium) wrote: > I believe the correct way to get these defines is to depend on > "//native_client/build/config/nacl:nacl_base" > In general, every target in the NaCl repo should depend on this target. > (Including the other ones you added.) Will do.
	9 sources = [

	10 "serialization.cc",

	11 "serialization.h",

	12 ]

	13 }

OLD	NEW

« build/toolchain/nacl/BUILD.gn ('K') | « build/toolchain/nacl/BUILD.gn ('k') | src/trusted/nonnacl_util/BUILD.gn » ('j') | src/trusted/nonnacl_util/BUILD.gn » ('J')