Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 893993003: Revert "MIPS:[turbofan] Improve unordered comparisons for boolean materialization." (Closed)

Created:
5 years, 10 months ago by paul.l...
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "MIPS:[turbofan] Improve unordered comparisons for boolean materialization." Reason for revert: Fails mjsunit/asm/embenchen/box2d BUG= Committed: https://crrev.com/a18dee6bba0cf4c93c0890623055e04732c60d22 Cr-Commit-Position: refs/heads/master@{#26444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -95 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 4 chunks +44 lines, -47 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +40 lines, -46 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
paul.l...
5 years, 10 months ago (2015-02-04 20:51:10 UTC) #2
akos.palfi.imgtec
lgtm
5 years, 10 months ago (2015-02-04 21:00:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893993003/1
5 years, 10 months ago (2015-02-04 21:06:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 21:28:48 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:29:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a18dee6bba0cf4c93c0890623055e04732c60d22
Cr-Commit-Position: refs/heads/master@{#26444}

Powered by Google App Engine
This is Rietveld 408576698