Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 893983002: Add helper methods to ServiceWorkerJobTest (Closed)

Created:
5 years, 10 months ago by Kunihiko Sakamoto
Modified:
5 years, 10 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add helper methods to ServiceWorkerJobTest To reduce the amount of repetition, this patch adds some helper methods to ServiceWorkerJobTest that run an asynchronous task and verifie the result. TEST=content_unittests --gtest_filter='ServiceWorkerJobTest.*' BUG= Committed: https://crrev.com/bc3def1a9c250292c314835387a9bfbbf372b6f3 Cr-Commit-Position: refs/heads/master@{#314234}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -247 lines) Patch
M content/browser/service_worker/service_worker_job_unittest.cc View 19 chunks +113 lines, -247 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Kunihiko Sakamoto
PTAL if you have time. Thanks! https://codereview.chromium.org/893983002/diff/1/content/browser/service_worker/service_worker_job_unittest.cc File content/browser/service_worker/service_worker_job_unittest.cc (left): https://codereview.chromium.org/893983002/diff/1/content/browser/service_worker/service_worker_job_unittest.cc#oldcode336 content/browser/service_worker/service_worker_job_unittest.cc:336: SERVICE_WORKER_OK, &called, &new_registration)); ...
5 years, 10 months ago (2015-02-02 11:01:32 UTC) #2
falken
lgtm, the tests are a lot a nicer now.
5 years, 10 months ago (2015-02-02 11:41:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893983002/1
5 years, 10 months ago (2015-02-03 01:25:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 01:30:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 01:32:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc3def1a9c250292c314835387a9bfbbf372b6f3
Cr-Commit-Position: refs/heads/master@{#314234}

Powered by Google App Engine
This is Rietveld 408576698