Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 893963005: Refactor handling of source map information. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index 0d4b38911d9bf6777dc1306ee7759f5b0aa1d29d..d32d59e11996c338f54dfde91782790fddd81044 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -16,37 +16,8 @@ class SsaCodeGeneratorTask extends CompilerTask {
js.Node attachPosition(js.Node node, AstElement element) {
- // TODO(sra): Attaching positions might be cleaner if the source position
- // was on a wrapping node.
- SourceFile sourceFile = sourceFileOfElement(element);
- String name = element.name;
- AstElement implementation = element.implementation;
- ast.Node expression = implementation.node;
- Token beginToken;
- Token endToken;
- if (expression == null) {
- // Synthesized node. Use the enclosing element for the location.
- beginToken = endToken = element.position;
- } else {
- beginToken = expression.getBeginToken();
- endToken = expression.getEndToken();
- }
- // TODO(podivilov): find the right sourceFile here and remove offset
- // checks below.
- var sourcePosition, endSourcePosition;
- if (beginToken.charOffset < sourceFile.length) {
- sourcePosition =
- new TokenSourceFileLocation(sourceFile, beginToken, name);
- }
- if (endToken.charOffset < sourceFile.length) {
- endSourcePosition =
- new TokenSourceFileLocation(sourceFile, endToken, name);
- }
- return node.withPosition(sourcePosition, endSourcePosition);
- }
-
- SourceFile sourceFileOfElement(Element element) {
- return element.implementation.compilationUnit.script.file;
+ return node.withSourceInformation(
+ StartEndSourceInformation.computeSourceInformation(element));
}
js.Fun buildJavaScriptFunction(FunctionElement element,
@@ -241,13 +212,12 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
js.Node attachLocation(js.Node jsNode, HInstruction instruction) {
- return jsNode.withLocation(instruction.sourcePosition);
+ return attachSourceInformation(jsNode, instruction.sourceInformation);
}
- js.Node attachLocationRange(js.Node jsNode,
- SourceFileLocation sourcePosition,
- SourceFileLocation endSourcePosition) {
- return jsNode.withPosition(sourcePosition, endSourcePosition);
+ js.Node attachSourceInformation(js.Node jsNode,
+ SourceInformation sourceInformation) {
+ return jsNode.withSourceInformation(sourceInformation);
}
void preGenerateMethod(HGraph graph) {
@@ -956,8 +926,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
compiler.internalError(condition.conditionExpression,
'Unexpected loop kind: ${info.kind}.');
}
- js.Statement result =
- attachLocationRange(loop, info.sourcePosition, info.endSourcePosition);
+ js.Statement result = attachSourceInformation(loop, info.sourceInformation);
if (info.kind == HLoopBlockInformation.SWITCH_CONTINUE_LOOP) {
String continueLabelString =
backend.namer.implicitContinueLabelName(info.target);

Powered by Google App Engine
This is Rietveld 408576698