Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 893963003: Make bucket required for GetIfChanged. (Closed)

Created:
5 years, 10 months ago by aiolos (Not reviewing)
Modified:
5 years, 10 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make bucket required for GetIfChanged. BUG=419551 Committed: https://crrev.com/04ce146caea02af2cc389c8ceae9233f787e7b26 Cr-Commit-Position: refs/heads/master@{#315169}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M tools/telemetry/telemetry/util/cloud_storage.py View 1 3 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aiolos (Not reviewing)
5 years, 10 months ago (2015-02-04 21:39:30 UTC) #2
dtu
lgtm
5 years, 10 months ago (2015-02-04 22:04:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893963003/20001
5 years, 10 months ago (2015-02-07 01:41:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-07 02:46:35 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 02:47:22 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04ce146caea02af2cc389c8ceae9233f787e7b26
Cr-Commit-Position: refs/heads/master@{#315169}

Powered by Google App Engine
This is Rietveld 408576698