| OLD | NEW |
| 1 # Copyright 2015 The Chromium Authors. All rights reserved. | 1 # Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Presubmit script for ui. | 5 """Presubmit script for ui. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| 11 INCLUDE_CPP_FILES_ONLY = ( | 11 INCLUDE_CPP_FILES_ONLY = ( |
| 12 r'.*\.(cc|h|mm)$', | 12 r'.*\.(cc|h|mm)$', |
| 13 ) | 13 ) |
| 14 | 14 |
| 15 def CheckScopedPtr(input_api, output_api, | 15 def CheckScopedPtr(input_api, output_api, |
| 16 white_list=INCLUDE_CPP_FILES_ONLY, black_list=None): | 16 white_list=INCLUDE_CPP_FILES_ONLY, black_list=None): |
| 17 black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST) | 17 black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST) |
| 18 source_file_filter = lambda x: input_api.FilterSourceFile(x, | 18 source_file_filter = lambda x: input_api.FilterSourceFile(x, |
| 19 white_list, | 19 white_list, |
| 20 black_list) | 20 black_list) |
| 21 errors = [] | 21 errors = [] |
| 22 for f in input_api.AffectedSourceFiles(source_file_filter): | 22 for f in input_api.AffectedSourceFiles(source_file_filter): |
| 23 for line_number, line in f.ChangedContents(): | 23 for line_number, line in f.ChangedContents(): |
| 24 # Disallow: | 24 # Disallow: |
| 25 # scoped_ptr<T>() | 25 # scoped_ptr<T>() |
| 26 if re.search(r'\bscoped_ptr<.*?>\(\)', line): | 26 if input_api.re.search(r'\bscoped_ptr<.*?>\(\)', line): |
| 27 errors.append(output_api.PresubmitError( | 27 errors.append(output_api.PresubmitError( |
| 28 '%s:%d uses scoped_ptr<T>(). Use nullptr instead.' % | 28 '%s:%d uses scoped_ptr<T>(). Use nullptr instead.' % |
| 29 (f.LocalPath(), line_number))) | 29 (f.LocalPath(), line_number))) |
| 30 return errors | 30 return errors |
| 31 | 31 |
| 32 | 32 |
| 33 def CheckChange(input_api, output_api): | 33 def CheckChange(input_api, output_api): |
| 34 results = [] | 34 results = [] |
| 35 results += CheckScopedPtr(input_api, output_api) | 35 results += CheckScopedPtr(input_api, output_api) |
| 36 return results | 36 return results |
| 37 | 37 |
| 38 | 38 |
| 39 def CheckChangeOnUpload(input_api, output_api): | 39 def CheckChangeOnUpload(input_api, output_api): |
| 40 return CheckChange(input_api, output_api) | 40 return CheckChange(input_api, output_api) |
| 41 | 41 |
| 42 | 42 |
| 43 def CheckChangeOnCommit(input_api, output_api): | 43 def CheckChangeOnCommit(input_api, output_api): |
| 44 return CheckChange(input_api, output_api) | 44 return CheckChange(input_api, output_api) |
| OLD | NEW |