Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 893913004: [turbofan] push virtual register field down to InstructionOperand (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] push virtual register field down to InstructionOperand BUG= Committed: https://crrev.com/81091e62b9330ff1294edd90fb012f8a85ff3866 Cr-Commit-Position: refs/heads/master@{#26377}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -128 lines) Patch
M src/compiler/instruction.h View 1 2 3 10 chunks +48 lines, -35 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 6 chunks +64 lines, -55 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 2 chunks +26 lines, -16 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Benedikt Meurer
LGTM https://codereview.chromium.org/893913004/diff/1/src/compiler/instruction-selector-impl.h File src/compiler/instruction-selector-impl.h (right): https://codereview.chromium.org/893913004/diff/1/src/compiler/instruction-selector-impl.h#newcode152 src/compiler/instruction-selector-impl.h:152: int GetVReg(Node* node) { return selector_->GetVirtualRegister(node); } nit: ...
5 years, 10 months ago (2015-02-02 08:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893913004/20001
5 years, 10 months ago (2015-02-02 09:02:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893913004/40001
5 years, 10 months ago (2015-02-02 09:22:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2572)
5 years, 10 months ago (2015-02-02 09:38:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893913004/60001
5 years, 10 months ago (2015-02-02 10:55:42 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-02 11:38:38 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 11:38:56 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/81091e62b9330ff1294edd90fb012f8a85ff3866
Cr-Commit-Position: refs/heads/master@{#26377}

Powered by Google App Engine
This is Rietveld 408576698