Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 893913003: Files.app: Fix closure compiler error. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix closure compiler error. BUG=None TEST=None Committed: https://crrev.com/8776e9ecf9f62e4dd4dbe5e8d3fba5830b2a6a95 Cr-Commit-Position: refs/heads/master@{#314114}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -28 lines) Patch
M ui/file_manager/file_manager/background/js/volume_manager.js View 1 2 4 chunks +11 lines, -26 lines 0 comments Download
M ui/file_manager/file_manager/background/js/volume_manager_unittest.js View 2 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hirono
PTAL? Thanks!
5 years, 10 months ago (2015-02-02 07:06:43 UTC) #2
yawano
Thank you! https://codereview.chromium.org/893913003/diff/20001/ui/file_manager/file_manager/background/js/volume_manager.js File ui/file_manager/file_manager/background/js/volume_manager.js (right): https://codereview.chromium.org/893913003/diff/20001/ui/file_manager/file_manager/background/js/volume_manager.js#newcode485 ui/file_manager/file_manager/background/js/volume_manager.js:485: this.model_.removeEventListener(handler); removeEventListener takes two arguments. - https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources/js/cr/event_target.js&l=50
5 years, 10 months ago (2015-02-02 07:29:36 UTC) #3
hirono
Thanks! https://codereview.chromium.org/893913003/diff/20001/ui/file_manager/file_manager/background/js/volume_manager.js File ui/file_manager/file_manager/background/js/volume_manager.js (right): https://codereview.chromium.org/893913003/diff/20001/ui/file_manager/file_manager/background/js/volume_manager.js#newcode485 ui/file_manager/file_manager/background/js/volume_manager.js:485: this.model_.removeEventListener(handler); On 2015/02/02 07:29:36, yawano wrote: > removeEventListener ...
5 years, 10 months ago (2015-02-02 07:35:56 UTC) #4
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-02 07:44:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893913003/40001
5 years, 10 months ago (2015-02-02 07:44:48 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-02 08:43:50 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 08:45:10 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8776e9ecf9f62e4dd4dbe5e8d3fba5830b2a6a95
Cr-Commit-Position: refs/heads/master@{#314114}

Powered by Google App Engine
This is Rietveld 408576698