chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc - Issue 893843009: Disable flaky test InlineLoginUISafeIframeBrowserTest.NavigationToOtherChromeURLDisallowed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Issue 893843009: Disable flaky test InlineLoginUISafeIframeBrowserTest.NavigationToOtherChromeURLDisallowed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

index 0f8d24e54c6278bafdf47153df4a9b63e1fbafec..5ec0bbc7b95fae159e2174cb49f63cf042cb7d9b 100644

--- a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

@@ -277,16 +277,9 @@ IN_PROC_BROWSER_TEST_F(InlineLoginUISafeIframeBrowserTest,

// Flaky on CrOS, http://crbug.com/364759.

// Also flaky on Mac, http://crbug.com/442674.

-#if defined(OS_CHROMEOS) || defined(OS_MACOSX)

-#define MAYBE_NavigationToOtherChromeURLDisallowed \

- DISABLED_NavigationToOtherChromeURLDisallowed

-#else

-#define MAYBE_NavigationToOtherChromeURLDisallowed \

- NavigationToOtherChromeURLDisallowed

-#endif

+// Also flaky on Linux which is just too flaky

Bernhard Bauer 2015/02/10 19:34:51 Please add a link to the bug.

IN_PROC_BROWSER_TEST_F(InlineLoginUISafeIframeBrowserTest,

- MAYBE_NavigationToOtherChromeURLDisallowed) {

+ DISABLED_NavigationToOtherChromeURLDisallowed) {

ui_test_utils::NavigateToURL(

browser(), signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false));

WaitUntilUIReady(browser());

« no previous file with comments | « no previous file | no next file » | no next file with comments »