chrome/browser/ui/views/tabs/tab.cc - Issue 893843007: Experiment to hide close buttons of inactive tabs when using touch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 893843007: Experiment to hide close buttons of inactive tabs when using touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added flag to histograms.xml Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tabs/tab.cc

diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc

index 29841163c87a34db0b811cabbf7030e9156b44aa..206443ea4b2986bb57adf67aed4bad6f0d568504 100644

--- a/chrome/browser/ui/views/tabs/tab.cc

+++ b/chrome/browser/ui/views/tabs/tab.cc

@@ -1444,6 +1444,9 @@ bool Tab::ShouldShowMediaIndicator() const {

}

bool Tab::ShouldShowCloseBox() const {

+ if (!IsActive() && controller_->ShouldHideCloseButtonForInactiveTab(this))

+ return false;

return chrome::ShouldTabShowCloseButton(

IconCapacity(), data().mini, IsActive());

}

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/views/tabs/tab_controller.h » ('j') | no next file with comments »