Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/about_flags.cc

Issue 893843007: Experiment to hide close buttons of inactive tabs when using touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 90b2ad6a7beeb0de16b66fa3c71b3e636d34f0f7..d5beff1c71e3411c71858b6ac5666dff93bd46a3 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -264,6 +264,18 @@ const Experiment::Choice kTabCaptureDownscaleQualityChoices[] = {
};
#endif
+#if defined(TOOLKIT_VIEWS)
+const Experiment::Choice kTabCloseButtonsHiddenWithTouchChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_ALWAYS,
+ switches::kTabCloseButtonsHiddenWithTouch, "always" },
+ { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_NARROW,
+ switches::kTabCloseButtonsHiddenWithTouch, "narrow" },
+ { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_STACKED,
+ switches::kTabCloseButtonsHiddenWithTouch, "stacked" },
+};
+#endif
+
#if defined(OS_ANDROID)
const Experiment::Choice kZeroSuggestExperimentsChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
@@ -1366,6 +1378,15 @@ const Experiment kExperiments[] = {
MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices)
},
#endif
+#if defined(TOOLKIT_VIEWS)
+ {
+ "tab-close-buttons-hidden-with-touch",
+ IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_NAME,
+ IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_DESCRIPTION,
+ kOsCrOS | kOsWin | kOsLinux,
+ MULTI_VALUE_TYPE(kTabCloseButtonsHiddenWithTouchChoices)
+ },
+#endif
{
"enable-webgl-draft-extensions",
IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_NAME,

Powered by Google App Engine
This is Rietveld 408576698