Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 893843007: Experiment to hide close buttons of inactive tabs when using touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added flag to histograms.xml Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 257 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
258 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST, 258 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
259 switches::kTabCaptureDownscaleQuality, "fast" }, 259 switches::kTabCaptureDownscaleQuality, "fast" },
260 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD, 260 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
261 switches::kTabCaptureDownscaleQuality, "good" }, 261 switches::kTabCaptureDownscaleQuality, "good" },
262 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST, 262 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
263 switches::kTabCaptureDownscaleQuality, "best" }, 263 switches::kTabCaptureDownscaleQuality, "best" },
264 }; 264 };
265 #endif 265 #endif
266 266
267 #if defined(TOOLKIT_VIEWS)
268 const Experiment::Choice kTabCloseButtonsHiddenWithTouchChoices[] = {
269 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
270 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_ALWAYS,
271 switches::kTabCloseButtonsHiddenWithTouch, "always" },
272 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_NARROW,
273 switches::kTabCloseButtonsHiddenWithTouch, "narrow" },
274 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_STACKED,
275 switches::kTabCloseButtonsHiddenWithTouch, "stacked" },
276 };
277 #endif
278
267 #if defined(OS_ANDROID) 279 #if defined(OS_ANDROID)
268 const Experiment::Choice kZeroSuggestExperimentsChoices[] = { 280 const Experiment::Choice kZeroSuggestExperimentsChoices[] = {
269 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 281 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
270 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED, 282 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED,
271 switches::kEnableZeroSuggestMostVisited, ""}, 283 switches::kEnableZeroSuggestMostVisited, ""},
272 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED_WITHOUT_SERP, 284 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED_WITHOUT_SERP,
273 switches::kEnableZeroSuggestMostVisitedWithoutSerp, ""}, 285 switches::kEnableZeroSuggestMostVisitedWithoutSerp, ""},
274 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 286 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
275 switches::kDisableZeroSuggest, ""} 287 switches::kDisableZeroSuggest, ""}
276 }; 288 };
(...skipping 1096 matching lines...) Expand 10 before | Expand all | Expand 10 after
1373 MULTI_VALUE_TYPE(kTabCaptureUpscaleQualityChoices) 1385 MULTI_VALUE_TYPE(kTabCaptureUpscaleQualityChoices)
1374 }, 1386 },
1375 { 1387 {
1376 "tab-capture-downscale-quality", 1388 "tab-capture-downscale-quality",
1377 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME, 1389 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME,
1378 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION, 1390 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION,
1379 kOsAll, 1391 kOsAll,
1380 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices) 1392 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices)
1381 }, 1393 },
1382 #endif 1394 #endif
1395 #if defined(TOOLKIT_VIEWS)
1396 {
1397 "tab-close-buttons-hidden-with-touch",
1398 IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_NAME,
1399 IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_DESCRIPTION,
1400 kOsCrOS | kOsWin | kOsLinux,
1401 MULTI_VALUE_TYPE(kTabCloseButtonsHiddenWithTouchChoices)
1402 },
1403 #endif
1383 { 1404 {
1384 "enable-webgl-draft-extensions", 1405 "enable-webgl-draft-extensions",
1385 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_NAME, 1406 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_NAME,
1386 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION, 1407 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION,
1387 kOsAll, 1408 kOsAll,
1388 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions) 1409 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions)
1389 }, 1410 },
1390 { 1411 {
1391 "enable-web-midi", 1412 "enable-web-midi",
1392 IDS_FLAGS_ENABLE_WEB_MIDI_NAME, 1413 IDS_FLAGS_ENABLE_WEB_MIDI_NAME,
(...skipping 1353 matching lines...) Expand 10 before | Expand all | Expand 10 after
2746 } 2767 }
2747 2768
2748 const Experiment* GetExperiments(size_t* count) { 2769 const Experiment* GetExperiments(size_t* count) {
2749 *count = num_experiments; 2770 *count = num_experiments;
2750 return experiments; 2771 return experiments;
2751 } 2772 }
2752 2773
2753 } // namespace testing 2774 } // namespace testing
2754 2775
2755 } // namespace about_flags 2776 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698