Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 893843007: Experiment to hide close buttons of inactive tabs when using touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 257 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
258 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST, 258 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
259 switches::kTabCaptureDownscaleQuality, "fast" }, 259 switches::kTabCaptureDownscaleQuality, "fast" },
260 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD, 260 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
261 switches::kTabCaptureDownscaleQuality, "good" }, 261 switches::kTabCaptureDownscaleQuality, "good" },
262 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST, 262 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
263 switches::kTabCaptureDownscaleQuality, "best" }, 263 switches::kTabCaptureDownscaleQuality, "best" },
264 }; 264 };
265 #endif 265 #endif
266 266
267 #if defined(TOOLKIT_VIEWS)
268 const Experiment::Choice kTabCloseButtonsHiddenWithTouchChoices[] = {
269 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
270 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_ALWAYS,
271 switches::kTabCloseButtonsHiddenWithTouch, "always" },
272 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_NARROW,
273 switches::kTabCloseButtonsHiddenWithTouch, "narrow" },
274 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_STACKED,
275 switches::kTabCloseButtonsHiddenWithTouch, "stacked" },
276 };
277 #endif
278
267 #if defined(OS_ANDROID) 279 #if defined(OS_ANDROID)
268 const Experiment::Choice kZeroSuggestExperimentsChoices[] = { 280 const Experiment::Choice kZeroSuggestExperimentsChoices[] = {
269 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 281 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
270 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED, 282 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED,
271 switches::kEnableZeroSuggestMostVisited, ""}, 283 switches::kEnableZeroSuggestMostVisited, ""},
272 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED_WITHOUT_SERP, 284 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED_WITHOUT_SERP,
273 switches::kEnableZeroSuggestMostVisitedWithoutSerp, ""}, 285 switches::kEnableZeroSuggestMostVisitedWithoutSerp, ""},
274 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 286 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
275 switches::kDisableZeroSuggest, ""} 287 switches::kDisableZeroSuggest, ""}
276 }; 288 };
(...skipping 1082 matching lines...) Expand 10 before | Expand all | Expand 10 after
1359 MULTI_VALUE_TYPE(kTabCaptureUpscaleQualityChoices) 1371 MULTI_VALUE_TYPE(kTabCaptureUpscaleQualityChoices)
1360 }, 1372 },
1361 { 1373 {
1362 "tab-capture-downscale-quality", 1374 "tab-capture-downscale-quality",
1363 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME, 1375 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME,
1364 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION, 1376 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION,
1365 kOsAll, 1377 kOsAll,
1366 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices) 1378 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices)
1367 }, 1379 },
1368 #endif 1380 #endif
1381 #if defined(TOOLKIT_VIEWS)
1382 {
1383 "tab-close-buttons-hidden-with-touch",
1384 IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_NAME,
1385 IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_DESCRIPTION,
1386 kOsCrOS | kOsWin | kOsLinux,
1387 MULTI_VALUE_TYPE(kTabCloseButtonsHiddenWithTouchChoices)
1388 },
1389 #endif
1369 { 1390 {
1370 "enable-webgl-draft-extensions", 1391 "enable-webgl-draft-extensions",
1371 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_NAME, 1392 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_NAME,
1372 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION, 1393 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION,
1373 kOsAll, 1394 kOsAll,
1374 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions) 1395 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions)
1375 }, 1396 },
1376 { 1397 {
1377 "enable-web-midi", 1398 "enable-web-midi",
1378 IDS_FLAGS_ENABLE_WEB_MIDI_NAME, 1399 IDS_FLAGS_ENABLE_WEB_MIDI_NAME,
(...skipping 1337 matching lines...) Expand 10 before | Expand all | Expand 10 after
2716 } 2737 }
2717 2738
2718 const Experiment* GetExperiments(size_t* count) { 2739 const Experiment* GetExperiments(size_t* count) {
2719 *count = num_experiments; 2740 *count = num_experiments;
2720 return experiments; 2741 return experiments;
2721 } 2742 }
2722 2743
2723 } // namespace testing 2744 } // namespace testing
2724 2745
2725 } // namespace about_flags 2746 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698