Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 893803003: Ensure that performance.memory is updated on first access. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ensure that performance.memory is updated on first access. A platform's implementation of monotonicallyIncreasingTime() is only required to be non-decreasing over time. Hence when checking if memory usage info should be updated for the first time, do not assume the function returns a value that will trigger the initial update. R=haraken BUG=454380 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/timing/MemoryInfo.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. An issue that Opera has run into on some platform embeddings; ...
5 years, 10 months ago (2015-02-02 13:43:52 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-02 13:57:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893803003/1
5 years, 10 months ago (2015-02-02 14:06:10 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 14:51:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189339

Powered by Google App Engine
This is Rietveld 408576698