Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4206)

Unified Diff: chrome/browser/android/banners/app_banner_manager.h

Issue 893793005: Check if there is a SW controlling the start page for app banner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager.h
diff --git a/chrome/browser/android/banners/app_banner_manager.h b/chrome/browser/android/banners/app_banner_manager.h
index c65d1479a5e62c29b3fe2019f5a223e7cdda43ec..263704d59a26ac685a4d1564c0a078d6d9863cc7 100644
--- a/chrome/browser/android/banners/app_banner_manager.h
+++ b/chrome/browser/android/banners/app_banner_manager.h
@@ -7,7 +7,9 @@
#include "base/android/jni_android.h"
#include "base/android/jni_weak_ref.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
#include "chrome/browser/android/banners/app_banner_infobar_delegate.h"
#include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
#include "content/public/browser/web_contents_observer.h"
@@ -125,6 +127,9 @@ class AppBannerManager : public chrome::BitmapFetcherDelegate,
const std::string& tag_content,
const GURL& expected_url);
+ // Called when the result of the CheckHasServiceWorker query has completed.
+ void OnDidCheckHasServiceWorker(bool has_same);
+
// Fetches the icon for an app.
scoped_ptr<chrome::BitmapFetcher> fetcher_;
GURL validated_url_;
@@ -134,6 +139,11 @@ class AppBannerManager : public chrome::BitmapFetcherDelegate,
// AppBannerManager on the Java side.
JavaObjectWeakGlobalRef weak_java_banner_view_manager_;
+ // A weak pointer is used as the lifetime of the ServiceWorkerContext is
+ // longer than the lifetime of this banner manager. The banner manager
+ // might be gone when calls sent to the ServiceWorkerContext are completed.
+ base::WeakPtrFactory<AppBannerManager> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(AppBannerManager);
}; // class AppBannerManager

Powered by Google App Engine
This is Rietveld 408576698