Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: content/browser/renderer_host/legacy_render_widget_host_win.cc

Issue 893773002: Add more logging to track down flakiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/legacy_render_widget_host_win.cc
diff --git a/content/browser/renderer_host/legacy_render_widget_host_win.cc b/content/browser/renderer_host/legacy_render_widget_host_win.cc
index f6804489457ea795b4824d47959ee0b7015e4438..a1e58819c09369350a3b77f867ddb49351b05044 100644
--- a/content/browser/renderer_host/legacy_render_widget_host_win.cc
+++ b/content/browser/renderer_host/legacy_render_widget_host_win.cc
@@ -147,6 +147,15 @@ LRESULT LegacyRenderWidgetHostHWND::OnGetObject(UINT message,
// because it sometimes gets sign-extended incorrectly (but not always).
DWORD obj_id = static_cast<DWORD>(static_cast<DWORD_PTR>(l_param));
+ // http://crbug.com/440579 TODO(dmazzoni): remove this logging when
+ // flakiness is fixed.
+ LOG(INFO) << "LegacyRenderWidgetHostHWND::OnGetObject"
+ << " message=" << message
+ << " w_param=" << w_param
+ << " l_param=" << l_param
+ << " obj_id=" << obj_id
+ << " host_=" << host_;
+
if (kIdScreenReaderHoneyPot == obj_id) {
// When an MSAA client has responded to our fake event on this id,
// enable screen reader support.
@@ -159,14 +168,18 @@ LRESULT LegacyRenderWidgetHostHWND::OnGetObject(UINT message,
RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(
host_->GetRenderWidgetHost());
- if (!rwhi)
+ if (!rwhi) {
+ LOG(WARNING) << "No RWHI";
return static_cast<LRESULT>(0L);
+ }
BrowserAccessibilityManagerWin* manager =
static_cast<BrowserAccessibilityManagerWin*>(
rwhi->GetRootBrowserAccessibilityManager());
- if (!manager)
+ if (!manager) {
+ LOG(WARNING) << "No manager";
return static_cast<LRESULT>(0L);
+ }
base::win::ScopedComPtr<IAccessible> root(
manager->GetRoot()->ToBrowserAccessibilityWin());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698