Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: gpu/command_buffer/client/program_info_manager.cc

Issue 893713002: Get rid of NonCachedProgramInfoManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/program_info_manager.cc
diff --git a/gpu/command_buffer/client/program_info_manager.cc b/gpu/command_buffer/client/program_info_manager.cc
index e167e38d91a8aa2f70b62ff8e379babff3afa42c..77dea50a88868e9260ca82009ebd9af5450882f8 100644
--- a/gpu/command_buffer/client/program_info_manager.cc
+++ b/gpu/command_buffer/client/program_info_manager.cc
@@ -4,421 +4,17 @@
#include "gpu/command_buffer/client/program_info_manager.h"
-#include <string>
-
-#include "base/compiler_specific.h"
-#include "base/containers/hash_tables.h"
-#include "base/synchronization/lock.h"
-#include "gpu/command_buffer/client/gles2_implementation.h"
-#include "gpu/command_buffer/common/gles2_cmd_utils.h"
-
namespace gpu {
namespace gles2 {
-class NonCachedProgramInfoManager : public ProgramInfoManager {
- public:
- NonCachedProgramInfoManager();
- ~NonCachedProgramInfoManager() override;
-
- void CreateInfo(GLuint program) override;
-
- void DeleteInfo(GLuint program) override;
-
- bool GetProgramiv(GLES2Implementation* gl,
- GLuint program,
- GLenum pname,
- GLint* params) override;
-
- GLint GetAttribLocation(GLES2Implementation* gl,
- GLuint program,
- const char* name) override;
-
- GLint GetUniformLocation(GLES2Implementation* gl,
- GLuint program,
- const char* name) override;
-
- GLint GetFragDataLocation(GLES2Implementation* gl,
- GLuint program,
- const char* name) override;
-
- bool GetActiveAttrib(GLES2Implementation* gl,
- GLuint program,
- GLuint index,
- GLsizei bufsize,
- GLsizei* length,
- GLint* size,
- GLenum* type,
- char* name) override;
-
- bool GetActiveUniform(GLES2Implementation* gl,
- GLuint program,
- GLuint index,
- GLsizei bufsize,
- GLsizei* length,
- GLint* size,
- GLenum* type,
- char* name) override;
-};
-
-NonCachedProgramInfoManager::NonCachedProgramInfoManager() {
-}
-
-NonCachedProgramInfoManager::~NonCachedProgramInfoManager() {
-}
-
-void NonCachedProgramInfoManager::CreateInfo(GLuint /* program */) {
-}
-
-void NonCachedProgramInfoManager::DeleteInfo(GLuint /* program */) {
-}
-
-bool NonCachedProgramInfoManager::GetProgramiv(
- GLES2Implementation* /* gl */,
- GLuint /* program */,
- GLenum /* pname */,
- GLint* /* params */) {
- return false;
-}
-
-GLint NonCachedProgramInfoManager::GetAttribLocation(
- GLES2Implementation* gl, GLuint program, const char* name) {
- return gl->GetAttribLocationHelper(program, name);
-}
-
-GLint NonCachedProgramInfoManager::GetUniformLocation(
- GLES2Implementation* gl, GLuint program, const char* name) {
- return gl->GetUniformLocationHelper(program, name);
-}
-
-GLint NonCachedProgramInfoManager::GetFragDataLocation(
- GLES2Implementation* gl, GLuint program, const char* name) {
- return gl->GetFragDataLocationHelper(program, name);
-}
-
-bool NonCachedProgramInfoManager::GetActiveAttrib(
- GLES2Implementation* gl,
- GLuint program, GLuint index, GLsizei bufsize, GLsizei* length,
- GLint* size, GLenum* type, char* name) {
- return gl->GetActiveAttribHelper(
- program, index, bufsize, length, size, type, name);
-}
-
-bool NonCachedProgramInfoManager::GetActiveUniform(
- GLES2Implementation* gl,
- GLuint program, GLuint index, GLsizei bufsize, GLsizei* length,
- GLint* size, GLenum* type, char* name) {
- return gl->GetActiveUniformHelper(
- program, index, bufsize, length, size, type, name);
-}
-
-class CachedProgramInfoManager : public ProgramInfoManager {
- public:
- CachedProgramInfoManager();
- ~CachedProgramInfoManager() override;
-
- void CreateInfo(GLuint program) override;
-
- void DeleteInfo(GLuint program) override;
-
- bool GetProgramiv(GLES2Implementation* gl,
- GLuint program,
- GLenum pname,
- GLint* params) override;
-
- GLint GetAttribLocation(GLES2Implementation* gl,
- GLuint program,
- const char* name) override;
-
- GLint GetUniformLocation(GLES2Implementation* gl,
- GLuint program,
- const char* name) override;
-
- GLint GetFragDataLocation(GLES2Implementation* gl,
- GLuint program,
- const char* name) override;
-
- bool GetActiveAttrib(GLES2Implementation* gl,
- GLuint program,
- GLuint index,
- GLsizei bufsize,
- GLsizei* length,
- GLint* size,
- GLenum* type,
- char* name) override;
-
- bool GetActiveUniform(GLES2Implementation* gl,
- GLuint program,
- GLuint index,
- GLsizei bufsize,
- GLsizei* length,
- GLint* size,
- GLenum* type,
- char* name) override;
-
- private:
- class Program {
- public:
- struct UniformInfo {
- UniformInfo(GLsizei _size, GLenum _type, const std::string& _name);
-
- GLsizei size;
- GLenum type;
- bool is_array;
- std::string name;
- std::vector<GLint> element_locations;
- };
- struct VertexAttrib {
- VertexAttrib(GLsizei _size, GLenum _type, const std::string& _name,
- GLint _location)
- : size(_size),
- type(_type),
- location(_location),
- name(_name) {
- }
- GLsizei size;
- GLenum type;
- GLint location;
- std::string name;
- };
-
- typedef std::vector<UniformInfo> UniformInfoVector;
- typedef std::vector<VertexAttrib> AttribInfoVector;
-
- Program();
-
- const AttribInfoVector& GetAttribInfos() const {
- return attrib_infos_;
- }
-
- const VertexAttrib* GetAttribInfo(GLint index) const {
- return (static_cast<size_t>(index) < attrib_infos_.size()) ?
- &attrib_infos_[index] : NULL;
- }
-
- GLint GetAttribLocation(const std::string& name) const;
-
- const UniformInfo* GetUniformInfo(GLint index) const {
- return (static_cast<size_t>(index) < uniform_infos_.size()) ?
- &uniform_infos_[index] : NULL;
- }
-
- // Gets the location of a uniform by name.
- GLint GetUniformLocation(const std::string& name) const;
-
- GLint GetFragDataLocation(const std::string& name) const;
- void CacheFragDataLocation(const std::string& name, GLint loc);
-
- bool GetProgramiv(GLenum pname, GLint* params);
-
- // Updates the program info after a successful link.
- void Update(GLES2Implementation* gl,
- GLuint program,
- const std::vector<int8>& result);
-
- bool cached() const { return cached_; }
-
- private:
- bool cached_;
-
- GLsizei max_attrib_name_length_;
-
- // Attrib by index.
- AttribInfoVector attrib_infos_;
-
- GLsizei max_uniform_name_length_;
-
- // Uniform info by index.
- UniformInfoVector uniform_infos_;
-
- base::hash_map<std::string, GLint> frag_data_locations_;
-
- // This is true if glLinkProgram was successful last time it was called.
- bool link_status_;
- };
-
- Program* GetProgramInfo(GLES2Implementation* gl, GLuint program);
-
- typedef base::hash_map<GLuint, Program> ProgramInfoMap;
-
- ProgramInfoMap program_infos_;
-
- mutable base::Lock lock_;
-};
-
-CachedProgramInfoManager::Program::UniformInfo::UniformInfo(
- GLsizei _size, GLenum _type, const std::string& _name)
- : size(_size),
- type(_type),
- name(_name) {
- is_array = (!name.empty() && name[name.size() - 1] == ']');
- DCHECK(!(size > 1 && !is_array));
-}
-
-CachedProgramInfoManager::Program::Program()
- : cached_(false),
- max_attrib_name_length_(0),
- max_uniform_name_length_(0),
- link_status_(false) {
-}
-
-// TODO(gman): Add a faster lookup.
-GLint CachedProgramInfoManager::Program::GetAttribLocation(
- const std::string& name) const {
- for (GLuint ii = 0; ii < attrib_infos_.size(); ++ii) {
- const VertexAttrib& info = attrib_infos_[ii];
- if (info.name == name) {
- return info.location;
- }
- }
- return -1;
-}
-
-GLint CachedProgramInfoManager::Program::GetUniformLocation(
- const std::string& name) const {
- bool getting_array_location = false;
- size_t open_pos = std::string::npos;
- int index = 0;
- if (!GLES2Util::ParseUniformName(
- name, &open_pos, &index, &getting_array_location)) {
- return -1;
- }
- for (GLuint ii = 0; ii < uniform_infos_.size(); ++ii) {
- const UniformInfo& info = uniform_infos_[ii];
- if (info.name == name ||
- (info.is_array &&
- info.name.compare(0, info.name.size() - 3, name) == 0)) {
- return info.element_locations[0];
- } else if (getting_array_location && info.is_array) {
- // Look for an array specification.
- size_t open_pos_2 = info.name.find_last_of('[');
- if (open_pos_2 == open_pos &&
- name.compare(0, open_pos, info.name, 0, open_pos) == 0) {
- if (index >= 0 && index < info.size) {
- return info.element_locations[index];
- }
- }
- }
- }
- return -1;
-}
-
-GLint CachedProgramInfoManager::Program::GetFragDataLocation(
- const std::string& name) const {
- base::hash_map<std::string, GLint>::const_iterator iter =
- frag_data_locations_.find(name);
- if (iter == frag_data_locations_.end())
- return -1;
- return iter->second;
-}
-
-void CachedProgramInfoManager::Program::CacheFragDataLocation(
- const std::string& name, GLint loc) {
- frag_data_locations_[name] = loc;
-}
-
-bool CachedProgramInfoManager::Program::GetProgramiv(
- GLenum pname, GLint* params) {
- switch (pname) {
- case GL_LINK_STATUS:
- *params = link_status_;
- return true;
- case GL_ACTIVE_ATTRIBUTES:
- *params = attrib_infos_.size();
- return true;
- case GL_ACTIVE_ATTRIBUTE_MAX_LENGTH:
- *params = max_attrib_name_length_;
- return true;
- case GL_ACTIVE_UNIFORMS:
- *params = uniform_infos_.size();
- return true;
- case GL_ACTIVE_UNIFORM_MAX_LENGTH:
- *params = max_uniform_name_length_;
- return true;
- default:
- break;
- }
- return false;
-}
-
-template<typename T> static T LocalGetAs(
- const std::vector<int8>& data, uint32 offset, size_t size) {
- const int8* p = &data[0] + offset;
- if (offset + size > data.size()) {
- NOTREACHED();
- return NULL;
- }
- return static_cast<T>(static_cast<const void*>(p));
-}
-
-void CachedProgramInfoManager::Program::Update(
- GLES2Implementation* gl,
- GLuint program,
- const std::vector<int8>& result) {
- if (cached_) {
- return;
- }
- if (result.empty()) {
- // This should only happen on a lost context.
- return;
- }
- DCHECK_GE(result.size(), sizeof(ProgramInfoHeader));
- const ProgramInfoHeader* header = LocalGetAs<const ProgramInfoHeader*>(
- result, 0, sizeof(header));
- link_status_ = header->link_status != 0;
- if (!link_status_) {
- return;
- }
- attrib_infos_.clear();
- uniform_infos_.clear();
- frag_data_locations_.clear();
- max_attrib_name_length_ = 0;
- max_uniform_name_length_ = 0;
- const ProgramInput* inputs = LocalGetAs<const ProgramInput*>(
- result, sizeof(*header),
- sizeof(ProgramInput) * (header->num_attribs + header->num_uniforms));
- const ProgramInput* input = inputs;
- for (uint32 ii = 0; ii < header->num_attribs; ++ii) {
- const int32* location = LocalGetAs<const int32*>(
- result, input->location_offset, sizeof(int32));
- const char* name_buf = LocalGetAs<const char*>(
- result, input->name_offset, input->name_length);
- std::string name(name_buf, input->name_length);
- attrib_infos_.push_back(
- VertexAttrib(input->size, input->type, name, *location));
- max_attrib_name_length_ = std::max(
- static_cast<GLsizei>(name.size() + 1), max_attrib_name_length_);
- ++input;
- }
- for (uint32 ii = 0; ii < header->num_uniforms; ++ii) {
- const int32* locations = LocalGetAs<const int32*>(
- result, input->location_offset, sizeof(int32) * input->size);
- const char* name_buf = LocalGetAs<const char*>(
- result, input->name_offset, input->name_length);
- std::string name(name_buf, input->name_length);
- UniformInfo info(input->size, input->type, name);
- max_uniform_name_length_ = std::max(
- static_cast<GLsizei>(name.size() + 1), max_uniform_name_length_);
- for (int32 jj = 0; jj < input->size; ++jj) {
- info.element_locations.push_back(locations[jj]);
- }
- uniform_infos_.push_back(info);
- ++input;
- }
- DCHECK_EQ(header->num_attribs + header->num_uniforms,
- static_cast<uint32>(input - inputs));
- cached_ = true;
-}
-
-CachedProgramInfoManager::CachedProgramInfoManager() {
+ProgramInfoManager::ProgramInfoManager() {
}
-CachedProgramInfoManager::~CachedProgramInfoManager() {
-
+ProgramInfoManager::~ProgramInfoManager() {
}
-CachedProgramInfoManager::Program*
- CachedProgramInfoManager::GetProgramInfo(
- GLES2Implementation* gl, GLuint program) {
+ProgramInfoManager::Program* ProgramInfoManager::GetProgramInfo(
+ GLES2Implementation* gl, GLuint program) {
lock_.AssertAcquired();
ProgramInfoMap::iterator it = program_infos_.find(program);
if (it == program_infos_.end()) {
@@ -444,7 +40,7 @@ CachedProgramInfoManager::Program*
return info;
}
-void CachedProgramInfoManager::CreateInfo(GLuint program) {
+void ProgramInfoManager::CreateInfo(GLuint program) {
base::AutoLock auto_lock(lock_);
program_infos_.erase(program);
std::pair<ProgramInfoMap::iterator, bool> result =
@@ -453,12 +49,12 @@ void CachedProgramInfoManager::CreateInfo(GLuint program) {
DCHECK(result.second);
}
-void CachedProgramInfoManager::DeleteInfo(GLuint program) {
+void ProgramInfoManager::DeleteInfo(GLuint program) {
base::AutoLock auto_lock(lock_);
program_infos_.erase(program);
}
-bool CachedProgramInfoManager::GetProgramiv(
+bool ProgramInfoManager::GetProgramiv(
GLES2Implementation* gl, GLuint program, GLenum pname, GLint* params) {
base::AutoLock auto_lock(lock_);
Program* info = GetProgramInfo(gl, program);
@@ -468,7 +64,7 @@ bool CachedProgramInfoManager::GetProgramiv(
return info->GetProgramiv(pname, params);
}
-GLint CachedProgramInfoManager::GetAttribLocation(
+GLint ProgramInfoManager::GetAttribLocation(
GLES2Implementation* gl, GLuint program, const char* name) {
{
base::AutoLock auto_lock(lock_);
@@ -480,7 +76,7 @@ GLint CachedProgramInfoManager::GetAttribLocation(
return gl->GetAttribLocationHelper(program, name);
}
-GLint CachedProgramInfoManager::GetUniformLocation(
+GLint ProgramInfoManager::GetUniformLocation(
GLES2Implementation* gl, GLuint program, const char* name) {
{
base::AutoLock auto_lock(lock_);
@@ -492,7 +88,7 @@ GLint CachedProgramInfoManager::GetUniformLocation(
return gl->GetUniformLocationHelper(program, name);
}
-GLint CachedProgramInfoManager::GetFragDataLocation(
+GLint ProgramInfoManager::GetFragDataLocation(
GLES2Implementation* gl, GLuint program, const char* name) {
// TODO(zmo): make FragData locations part of the ProgramInfo that are
// fetched altogether from the service side. See crbug.com/452104.
@@ -516,7 +112,7 @@ GLint CachedProgramInfoManager::GetFragDataLocation(
return loc;
}
-bool CachedProgramInfoManager::GetActiveAttrib(
+bool ProgramInfoManager::GetActiveAttrib(
GLES2Implementation* gl,
GLuint program, GLuint index, GLsizei bufsize, GLsizei* length,
GLint* size, GLenum* type, char* name) {
@@ -552,7 +148,7 @@ bool CachedProgramInfoManager::GetActiveAttrib(
program, index, bufsize, length, size, type, name);
}
-bool CachedProgramInfoManager::GetActiveUniform(
+bool ProgramInfoManager::GetActiveUniform(
GLES2Implementation* gl,
GLuint program, GLuint index, GLsizei bufsize, GLsizei* length,
GLint* size, GLenum* type, char* name) {
@@ -588,21 +184,6 @@ bool CachedProgramInfoManager::GetActiveUniform(
program, index, bufsize, length, size, type, name);
}
-ProgramInfoManager::ProgramInfoManager() {
-}
-
-ProgramInfoManager::~ProgramInfoManager() {
-}
-
-ProgramInfoManager* ProgramInfoManager::Create(
- bool shared_resources_across_processes) {
- if (shared_resources_across_processes) {
- return new NonCachedProgramInfoManager();
- } else {
- return new CachedProgramInfoManager();
- }
-}
-
} // namespace gles2
} // namespace gpu

Powered by Google App Engine
This is Rietveld 408576698