Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 893703003: Save and temp dst and src FBO on GrGLGpu and use the temp FBOs for copySurface if needed. (Closed)

Created:
5 years, 10 months ago by egdaniel
Modified:
5 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Save and temp dst and src FBO on GrGLGpu and use the temp FBOs for copySurface if needed. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0f5f967f6777612353c762e6d0095f733adfb326

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 1

Patch Set 3 : Updates from review #

Total comments: 3

Patch Set 4 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -29 lines) Patch
M src/gpu/gl/GrGLGpu.h View 1 2 3 2 chunks +12 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 14 chunks +45 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
egdaniel
ptal
5 years, 10 months ago (2015-02-02 18:55:49 UTC) #2
bsalomon
https://codereview.chromium.org/893703003/diff/20001/src/gpu/gl/GrGLGpu.h File src/gpu/gl/GrGLGpu.h (right): https://codereview.chromium.org/893703003/diff/20001/src/gpu/gl/GrGLGpu.h#newcode315 src/gpu/gl/GrGLGpu.h:315: struct TempFBO { Maybe it'd be better to just ...
5 years, 10 months ago (2015-02-02 21:33:01 UTC) #3
egdaniel
updated
5 years, 10 months ago (2015-02-03 16:11:10 UTC) #4
bsalomon
lgtm https://codereview.chromium.org/893703003/diff/40001/src/gpu/gl/GrGLGpu.cpp File src/gpu/gl/GrGLGpu.cpp (right): https://codereview.chromium.org/893703003/diff/40001/src/gpu/gl/GrGLGpu.cpp#newcode2553 src/gpu/gl/GrGLGpu.cpp:2553: GR_GL_CALL(this->glInterface(), FramebufferTexture2D(fboTarget, should we inc the rt bind ...
5 years, 10 months ago (2015-02-03 17:06:24 UTC) #5
egdaniel
https://codereview.chromium.org/893703003/diff/40001/src/gpu/gl/GrGLGpu.cpp File src/gpu/gl/GrGLGpu.cpp (right): https://codereview.chromium.org/893703003/diff/40001/src/gpu/gl/GrGLGpu.cpp#newcode2553 src/gpu/gl/GrGLGpu.cpp:2553: GR_GL_CALL(this->glInterface(), FramebufferTexture2D(fboTarget, On 2015/02/03 17:06:24, bsalomon wrote: > should ...
5 years, 10 months ago (2015-02-03 18:50:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893703003/60001
5 years, 10 months ago (2015-02-03 18:51:09 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:10:55 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/0f5f967f6777612353c762e6d0095f733adfb326

Powered by Google App Engine
This is Rietveld 408576698