Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 893703002: Suggestions and merge in the other CL. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Suggestions and merge in the other CL. I had some suggestions on the subset CL, and took the opportunity to rebase it against head and merge in the other color type CL. BUG=skia: Committed: https://skia.googlesource.com/skia/+/edc93bc74003e2c19219ba0b30383868b5371a96

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M dm/DM.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M dm/DMSrcSink.h View 1 chunk +4 lines, -2 lines 2 comments Download
M dm/DMSrcSink.cpp View 3 chunks +24 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
scroggo
lgtm https://codereview.chromium.org/893703002/diff/1/dm/DMSrcSink.h File dm/DMSrcSink.h (right): https://codereview.chromium.org/893703002/diff/1/dm/DMSrcSink.h#newcode72 dm/DMSrcSink.h:72: Path fPath; The other CL made this const. ...
5 years, 10 months ago (2015-01-30 21:15:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893703002/1
5 years, 10 months ago (2015-01-30 21:15:51 UTC) #4
mtklein
https://codereview.chromium.org/893703002/diff/1/dm/DMSrcSink.h File dm/DMSrcSink.h (right): https://codereview.chromium.org/893703002/diff/1/dm/DMSrcSink.h#newcode72 dm/DMSrcSink.h:72: Path fPath; On 2015/01/30 21:15:09, scroggo wrote: > The ...
5 years, 10 months ago (2015-01-30 21:16:42 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 21:22:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/edc93bc74003e2c19219ba0b30383868b5371a96

Powered by Google App Engine
This is Rietveld 408576698