Fix bug where requests to QUIC servers were throttled by the resource scheduler.

Fix bug where requests to QUIC servers were throttled by the resource scheduler.

Committed: https://crrev.com/9c3e338015e3bbb1bfc1e892b076eb7411aee43f
Cr-Commit-Position: refs/heads/master@{#314032}

[Ryan Hamilton, 2015-01-30 20:32:40]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[ramant (doing other things), 2015-01-30 20:54:43]

lgtm

[Ryan Hamilton, 2015-01-30 21:10:15]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-01-30 21:11:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/893693002/20001

[commit-bot: I haz the power, 2015-01-30 21:18:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 21:18:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ryan Hamilton, 2015-01-30 21:36:48]

rch@chromium.org changed reviewers:
+ mmenke@chromium.org

[Ryan Hamilton, 2015-01-30 21:36:49]

mmenke: content/browser/loader/resource_scheduler.cc OWNERS review. (The only
change to that file is a rename of a method in net/)

[mmenke, 2015-01-30 22:04:16]

Should search for SPDY in ResourceScheduler and figure out where "SPDY or QUIC"
(Or something more general) fits instead.  Otherwise, LGTM

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
File content/browser/loader/resource_scheduler.cc (right):

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
content/browser/loader/resource_scheduler.cc:305: using_spdy_proxy_(false),
Is there a QUIC proxy being worked on?

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
content/browser/loader/resource_scheduler.cc:476: // The priority and SPDY
support may have changed, so update the
This now applies to QUIC, too.

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
content/browser/loader/resource_scheduler.cc:671: //   * Non-delayable,
High-priority and SPDY capable requests are issued
This now applies to QUIC, too

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
content/browser/loader/resource_scheduler.cc:724: // crbug.com/164101. Also,
theoretically we should not count a SPDY request
This now applies to QUIC, too

[Ryan Hamilton, 2015-01-30 22:53:47]

Thanks. I believe I changed all the references to (non-proxy) SPDY in resource
scheduler. I'll work on the proxy-specific behavior in a subsequent CL.

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
File content/browser/loader/resource_scheduler.cc (right):

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
content/browser/loader/resource_scheduler.cc:305: using_spdy_proxy_(false),
On 2015/01/30 22:04:16, mmenke wrote:
> Is there a QUIC proxy being worked on?

Yes, it's just getting started. We'll need to make sure we get this plumbed
through as well.

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
content/browser/loader/resource_scheduler.cc:476: // The priority and SPDY
support may have changed, so update the
On 2015/01/30 22:04:16, mmenke wrote:
> This now applies to QUIC, too.

Done.

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
content/browser/loader/resource_scheduler.cc:671: //   * Non-delayable,
High-priority and SPDY capable requests are issued
On 2015/01/30 22:04:16, mmenke wrote:
> This now applies to QUIC, too

Done.

https://codereview.chromium.org/893693002/diff/20001/content/browser/loader/r...
content/browser/loader/resource_scheduler.cc:724: // crbug.com/164101. Also,
theoretically we should not count a SPDY request
On 2015/01/30 22:04:16, mmenke wrote:
> This now applies to QUIC, too

Done.

[Ryan Hamilton, 2015-01-30 22:53:57]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-01-30 22:54:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/893693002/40001

[commit-bot: I haz the power, 2015-01-30 22:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 22:57:48]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ryan Hamilton, 2015-01-30 23:02:39]

Patchset #3 (id:40001) has been deleted

[Ryan Hamilton, 2015-01-30 23:02:46]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-01-30 23:04:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/893693002/60001

[commit-bot: I haz the power, 2015-01-30 23:58:06]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-01-30 23:59:07]

Patchset 3 (id:??) landed as
https://crrev.com/9c3e338015e3bbb1bfc1e892b076eb7411aee43f
Cr-Commit-Position: refs/heads/master@{#314032}