Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2423)

Unified Diff: Source/web/PageWidgetDelegate.cpp

Issue 893683003: Implement top controls show/hide functionality for main thread scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix minor macro issue Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/PageWidgetDelegate.cpp
diff --git a/Source/web/PageWidgetDelegate.cpp b/Source/web/PageWidgetDelegate.cpp
index 72341ae700d6de189ef837d60138eaab10b6b086..bd1c02af4f4383884bbf7cf4e2a5d4dda82dbd68 100644
--- a/Source/web/PageWidgetDelegate.cpp
+++ b/Source/web/PageWidgetDelegate.cpp
@@ -174,15 +174,12 @@ bool PageWidgetDelegate::handleInputEvent(PageWidgetEventHandler& handler, const
if (!root || !root->view())
return false;
return handler.handleTouchEvent(*root, static_cast<const WebTouchEvent&>(event));
-
case WebInputEvent::GesturePinchBegin:
case WebInputEvent::GesturePinchEnd:
case WebInputEvent::GesturePinchUpdate:
- // FIXME: Once PlatformGestureEvent is updated to support pinch, this
- // should call handleGestureEvent, just like it currently does for
- // gesture scroll.
+ // Touchscreen pinch events are currently not handled in main thread. Once they are,
+ // these should be passed to |handleGestureEvent| similar to gesture scroll events.
return false;
-
default:
return false;
}

Powered by Google App Engine
This is Rietveld 408576698