Enhance the DBus interface for peerd

dbus/message.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "dbus/message.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/format_macros.h"
@@ skipping 819 matching lines @@
 bool MessageReader::PopArrayOfStrings(
     std::vector<std::string> *strings) {
   strings->clear();
   MessageReader array_reader(message_);
   if (!PopArray(&array_reader))
     return false;
   while (array_reader.HasMoreData()) {
     std::string string;
     if (!array_reader.PopString(&string))
       return false;
-    strings->push_back(string);
+    strings->push_back(std::move(string));

[satorux1, 2015/02/05 08:20:15]

This change seems to be unrelated to the purpose of the patch. If needed, maybe
do this in a separate patch?

[hashimoto, 2015/02/05 09:51:12]

move semantics is not allowed yet.
http://chromium-cpp.appspot.com/

[dtapuska, 2015/02/05 19:51:17]

Done.

   }
   return true;
 }
 
 bool MessageReader::PopArrayOfObjectPaths(
     std::vector<ObjectPath> *object_paths) {
   object_paths->clear();
   MessageReader array_reader(message_);
   if (!PopArray(&array_reader))
     return false;
@@ skipping 141 matching lines @@
   const bool success = PopBasic(DBUS_TYPE_UNIX_FD, &fd);
   if (!success)
     return false;
 
   value->PutValue(fd);
   // NB: the caller must check validity before using the value
   return true;
 }
 
 }  // namespace dbus