Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 893643002: Add a standalone SkyShell.apk for testing (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a standalone SkyShell.apk for testing This CL adds a SkyShell.apk, which will become a direct embedding of Sky on Android that will let us run performance tests on the Sky engine in a self-contained environment on a real device. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/76ac67828838bc2a8a5e7a6125ab4f45182af7cd

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -48 lines) Patch
M sky/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
A sky/shell/BUILD.gn View 1 1 chunk +69 lines, -0 lines 0 comments Download
A + sky/shell/apk/AndroidManifest.xml View 2 chunks +5 lines, -10 lines 0 comments Download
A + sky/shell/apk/res/values/strings.xml View 1 chunk +1 line, -4 lines 0 comments Download
A sky/shell/apk/src/org/domokit/sky/shell/SkyMain.java View 1 chunk +50 lines, -0 lines 0 comments Download
A sky/shell/apk/src/org/domokit/sky/shell/SkyShellActivity.java View 1 chunk +24 lines, -0 lines 0 comments Download
A + sky/shell/apk/src/org/domokit/sky/shell/SkyShellApplication.java View 1 3 chunks +6 lines, -15 lines 0 comments Download
A + sky/shell/library_loader.cc View 2 chunks +6 lines, -13 lines 0 comments Download
A + sky/shell/sky_main.h View 1 chunk +9 lines, -6 lines 0 comments Download
A sky/shell/sky_main.cc View 1 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-01-30 18:36:42 UTC) #1
eseidel
lgtm https://codereview.chromium.org/893643002/diff/1/sky/shell/BUILD.gn File sky/shell/BUILD.gn (right): https://codereview.chromium.org/893643002/diff/1/sky/shell/BUILD.gn#newcode39 sky/shell/BUILD.gn:39: ldflags = [ "-Wl,--export-dynamic" ] Is this hold-over ...
5 years, 10 months ago (2015-01-30 21:57:56 UTC) #2
abarth-chromium
https://codereview.chromium.org/893643002/diff/1/sky/shell/BUILD.gn File sky/shell/BUILD.gn (right): https://codereview.chromium.org/893643002/diff/1/sky/shell/BUILD.gn#newcode39 sky/shell/BUILD.gn:39: ldflags = [ "-Wl,--export-dynamic" ] On 2015/01/30 at 21:57:56, ...
5 years, 10 months ago (2015-01-30 22:02:28 UTC) #3
abarth-chromium
5 years, 10 months ago (2015-01-30 22:06:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
76ac67828838bc2a8a5e7a6125ab4f45182af7cd.

Powered by Google App Engine
This is Rietveld 408576698