Issue 893623002: Revert of Flip flag to turn CrOS Browser Compositor Single Threaded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 893623002: Revert of Flip flag to turn CrOS Browser Compositor Single Threaded (Closed)

Created:
5 years, 10 months ago by weiliangc

Modified:
5 years, 10 months ago

Reviewers:
danakj, piman

CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick, enne (OOO), jamesr, jbauman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Flip flag to turn CrOS Browser Compositor Single Threaded (patchset #5 id:80001 of https://codereview.chromium.org/781163003/) Reason for revert: Possible cause for veyron: Chrome crash in SW Mirror mode (at login screen) https://code.google.com/p/chromium/issues/detail?id=453732 Original issue's description: > Flip flag to turn CrOS Browser Compositor Single Threaded > > Simply stop using threaded browser compositor for CrOS. Clean up would > be in follow up patch. > > R=danakj@chromium.org, piman@chromium.org > BUG=329552 > > Committed: https://crrev.com/e111a7d64d9ba12833900ab743beaf4ee6d267ed > Cr-Commit-Position: refs/heads/master@{#313842} TBR=danakj@chromium.org,piman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=329552 Committed: https://crrev.com/67bf7866e888bb31b4d05869a11b17a3bf93199f Cr-Commit-Position: refs/heads/master@{#313950}

Patch Set 1 #

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
	M	content/browser/compositor/gpu_process_transport_factory.cc	View		2 chunks	+11 lines, -2 lines	0 comments	Download
	M	ui/compositor/test/in_process_context_factory.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

weiliangc

Created Revert of Flip flag to turn CrOS Browser Compositor Single Threaded

5 years, 10 months ago (2015-01-30 18:28:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893623002/1

5 years, 10 months ago (2015-01-30 18:29:13 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-01-30 18:32:21 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/67bf7866e888bb31b4d05869a11b17a3bf93199f
Cr-Commit-Position: refs/heads/master@{#313950}

Expand Messages | Collapse Messages