Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Issue 893603006: extensions: darken some disabled text for better contrast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/extensions/extensions.css ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(dbeam): test for loading upacked extensions? 5 // TODO(dbeam): test for loading upacked extensions?
6 6
7 GEN('#include "chrome/browser/ui/webui/extensions/' + 7 GEN('#include "chrome/browser/ui/webui/extensions/' +
8 'extension_settings_browsertest.h"'); 8 'extension_settings_browsertest.h"');
9 9
10 /** 10 /**
(...skipping 12 matching lines...) Expand all
23 23
24 ExtensionSettingsWebUITest.prototype = { 24 ExtensionSettingsWebUITest.prototype = {
25 __proto__: testing.Test.prototype, 25 __proto__: testing.Test.prototype,
26 26
27 /** @override */ 27 /** @override */
28 runAccessibilityChecks: true, 28 runAccessibilityChecks: true,
29 29
30 /** @override */ 30 /** @override */
31 accessibilityIssuesAreErrors: true, 31 accessibilityIssuesAreErrors: true,
32 32
33 /** @override */
34 setUp: function() {
35 // TODO(aboxhall): remove these when crbug.com/267035 is closed.
36 this.accessibilityAuditConfig.ignoreSelectors(
Dan Beam 2015/01/30 22:07:03 I also deleted this line[1] to make sure the tests
37 'lowContrastElements',
38 '.enable-checkbox input:disabled + .enable-checkbox-text > *');
39 this.accessibilityAuditConfig.ignoreSelectors(
40 'lowContrastElements', '.extension-description > *');
41 this.accessibilityAuditConfig.ignoreSelectors(
42 'lowContrastElements', '.location-text');
43 },
44
45 /** 33 /**
46 * A URL to load before starting each test. 34 * A URL to load before starting each test.
47 * @type {string} 35 * @type {string}
48 * @const 36 * @const
49 */ 37 */
50 browsePreload: 'chrome://extensions-frame/', 38 browsePreload: 'chrome://extensions-frame/',
51 39
52 /** @override */ 40 /** @override */
53 typedefCppFixture: 'ExtensionSettingsUIBrowserTest', 41 typedefCppFixture: 'ExtensionSettingsUIBrowserTest',
54 }; 42 };
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 testGenPreamble: function() { 123 testGenPreamble: function() {
136 GEN(' InstallGoodExtension();'); 124 GEN(' InstallGoodExtension();');
137 } 125 }
138 }; 126 };
139 127
140 TEST_F('ExtensionSettingsWebUITestWithExtensionInstalled', 128 TEST_F('ExtensionSettingsWebUITestWithExtensionInstalled',
141 'baseAccessibilityIsOk', function() { 129 'baseAccessibilityIsOk', function() {
142 assertEquals(this.browsePreload, document.location.href); 130 assertEquals(this.browsePreload, document.location.href);
143 this.runAccessibilityAudit(); 131 this.runAccessibilityAudit();
144 }); 132 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/extensions/extensions.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698