Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 893603006: extensions: darken some disabled text for better contrast. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

extensions: darken some disabled text for better contrast. This is the Accessibility Developer Tools suggested color for a 4.5 contrast ratio (minimum for AA rating[1] / audit to stop barking). R=kalman@chromium.org BUG=439227 [1] http://www.w3.org/WAI/WCAG2AA-Conformance Committed: https://crrev.com/7a5f18904bdb7948a877e96fb4b9f5a5e481447a Cr-Commit-Position: refs/heads/master@{#314022}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M chrome/browser/resources/extensions/extensions.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.js View 1 chunk +0 lines, -12 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Dan Beam
https://codereview.chromium.org/893603006/diff/1/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js File chrome/browser/ui/webui/extensions/extension_settings_browsertest.js (left): https://codereview.chromium.org/893603006/diff/1/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js#oldcode36 chrome/browser/ui/webui/extensions/extension_settings_browsertest.js:36: this.accessibilityAuditConfig.ignoreSelectors( I also deleted this line[1] to make sure ...
5 years, 10 months ago (2015-01-30 22:07:03 UTC) #1
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-01-30 22:32:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893603006/1
5 years, 10 months ago (2015-01-30 22:34:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 23:17:42 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 23:18:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a5f18904bdb7948a877e96fb4b9f5a5e481447a
Cr-Commit-Position: refs/heads/master@{#314022}

Powered by Google App Engine
This is Rietveld 408576698