Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1900)

Issue 893603003: Update permission prompt icons (Closed)

Created:
5 years, 10 months ago by felt
Modified:
5 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, sashab, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update permission prompt icons This updates the permission prompt (infobar and permission bubble) icons with the new icons provided by sgabriel@: https://drive.google.com/a/google.com/folderview?id=0B-Vmdj5n- YddWktRd1BMeHZYWWs&usp=sharing BUG=451490 Committed: https://crrev.com/9dd8cd76747530737ce700b21fa2e8514c07ffb7 Cr-Commit-Position: refs/heads/master@{#314007}

Patch Set 1 #

Patch Set 2 : pngcrushed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/theme/default_100_percent/common/allowed_midi.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/infobar_desktop_notifications.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/infobar_geolocation.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/infobar_media_stream_camera.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/infobar_media_stream_mic.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/infobar_multiple_downloads.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/allowed_midi.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/infobar_desktop_notifications.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/infobar_geolocation.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/infobar_media_stream_camera.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/infobar_media_stream_mic.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/infobar_multiple_downloads.png View 1 Binary file 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_request.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
felt
* Markus, please review. * Sasha, I don't think Android PageInfo uses the same resources ...
5 years, 10 months ago (2015-01-30 15:52:30 UTC) #2
palmer
> * Palmer, FYI because some of these assets are the same as the ones ...
5 years, 10 months ago (2015-01-30 19:34:00 UTC) #3
markusheintz_
On 2015/01/30 19:34:00, palmer (OOO until 30-03-2015) wrote: > > * Palmer, FYI because some ...
5 years, 10 months ago (2015-01-30 20:07:06 UTC) #4
felt
On 2015/01/30 20:07:06, markusheintz_ wrote: > On 2015/01/30 19:34:00, palmer (OOO until 30-03-2015) wrote: > ...
5 years, 10 months ago (2015-01-30 21:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893603003/20001
5 years, 10 months ago (2015-01-30 21:24:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39557)
5 years, 10 months ago (2015-01-30 21:31:14 UTC) #9
felt
oshima@, PTAL?
5 years, 10 months ago (2015-01-30 21:40:05 UTC) #11
oshima
lgtm
5 years, 10 months ago (2015-01-30 21:50:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893603003/20001
5 years, 10 months ago (2015-01-30 21:54:16 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 22:16:13 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9dd8cd76747530737ce700b21fa2e8514c07ffb7 Cr-Commit-Position: refs/heads/master@{#314007}
5 years, 10 months ago (2015-01-30 22:17:13 UTC) #16
sashab
5 years, 10 months ago (2015-02-02 12:19:58 UTC) #18
Message was sent while issue was closed.
Sorry, was on a plane when this was landed; no, PageInfo doesn't share these
resources.

Powered by Google App Engine
This is Rietveld 408576698