Issue 8936006: Fix MinGW build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8936006: Fix MinGW build. (Closed)

Created:
9 years ago by Yang

Modified:
8 years, 11 months ago

Reviewers:
yext

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix MinGW build. BUG=v8:1724

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/win32-headers.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Please confirm that this fixes the MinGW build (since it apparently has been broken in ...

9 years ago (2011-12-13 14:12:06 UTC) #1

yext

9 years ago (2011-12-13 14:34:02 UTC) #2

On 2011/12/13 14:12:06, Yang wrote:
> Please confirm that this fixes the MinGW build (since it apparently has been
> broken in r9471).

Yes this patch fixed the problem of r9471. Thanks.

However it's still unable to build a shared library under MinGW, it will have
some undefined reference errors. The solution is to add library references
"winmm" and "ws2_32" to MinGW shared library settings. So can you please write a
patch for this issue? Thanks.

Expand Messages | Collapse Messages