Expose the "Fullscreen" content setting to extensions.

Expose the "Fullscreen" content setting to extensions.

BUG=451075
Committed: https://crrev.com/6b98a5a5b22feca6c4824d94b9157c3c1ca0e48c
Cr-Commit-Position: refs/heads/master@{#314339}

[msramek, 2015-01-30 17:52:20]

Patchset #1 (id:1) has been deleted

[msramek, 2015-02-02 10:30:43]

msramek@chromium.org changed reviewers:
+ kalman@chromium.org, markusheintz@chromium.org, mkwst@chromium.org

[msramek, 2015-02-02 10:30:44]

Hello,

another addition to the extensions API - fullscreen setting. (camera and mic are
not landed yet, but this is before them in the ordering, so it can be done in
parallel without extra rebase)

PTAL :)

Thanks,
Martin

https://codereview.chromium.org/893543003/diff/20001/components/content_setti...
File components/content_settings/core/browser/host_content_settings_map.cc
(right):

https://codereview.chromium.org/893543003/diff/20001/components/content_setti...
components/content_settings/core/browser/host_content_settings_map.cc:523: case
CONTENT_SETTINGS_TYPE_FULLSCREEN:
This function had only approved ALLOW and DEFAULT as valid values for
FULLSCREEN. ASK was not, although that is the actual default behavior.

markusheintz@, this is one of the things we talked about this morning; I'm not
breaking anything here, I guess?

[Mike West, 2015-02-02 10:34:12]

mkwst@chromium.org changed required reviewers:
+ kalman@chromium.org, markusheintz@chromium.org

[Mike West, 2015-02-02 10:34:12]

LGTM, but please wait for markusheintz@ to sign off on the content settings
change, and kalman@ to sign off on the extensions change.

[markusheintz_, 2015-02-02 14:29:32]

https://codereview.chromium.org/893543003/diff/20001/components/content_setti...
File components/content_settings/core/browser/host_content_settings_map.cc
(right):

https://codereview.chromium.org/893543003/diff/20001/components/content_setti...
components/content_settings/core/browser/host_content_settings_map.cc:523: case
CONTENT_SETTINGS_TYPE_FULLSCREEN:
It would be great if you could add a test for this to the unittests

[not at google - send to devlin, 2015-02-02 19:18:29]

lgtm

[msramek, 2015-02-03 13:24:42]

https://codereview.chromium.org/893543003/diff/20001/components/content_setti...
File components/content_settings/core/browser/host_content_settings_map.cc
(right):

https://codereview.chromium.org/893543003/diff/20001/components/content_setti...
components/content_settings/core/browser/host_content_settings_map.cc:523: case
CONTENT_SETTINGS_TYPE_FULLSCREEN:
On 2015/02/02 14:29:32, markusheintz_ wrote:
> It would be great if you could add a test for this to the unittests

Added a new test to host_content_settings_map_unittest.cc, PTAL.

[markusheintz_, 2015-02-03 13:44:32]

LGTM

[markusheintz_, 2015-02-03 13:44:45]

On 2015/02/03 13:44:32, markusheintz_ wrote:
> LGTM

Thanks a lot for adding the unittest

[msramek, 2015-02-03 13:46:18]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-02-03 13:46:32]

The CQ bit was unchecked by msramek@chromium.org

[msramek, 2015-02-03 13:51:22]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-02-03 13:51:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/893543003/40001

[commit-bot: I haz the power, 2015-02-03 15:42:27]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-02-03 15:43:30]

Patchset 2 (id:??) landed as
https://crrev.com/6b98a5a5b22feca6c4824d94b9157c3c1ca0e48c
Cr-Commit-Position: refs/heads/master@{#314339}