Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: src/arm64/macro-assembler-arm64.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/base/logging.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/division-by-constant.h" 10 #include "src/base/division-by-constant.h"
(...skipping 3918 matching lines...) Expand 10 before | Expand all | Expand 10 after
3929 Ldrb(scratch, FieldMemOperand(scratch, Map::kInstanceTypeOffset)); 3929 Ldrb(scratch, FieldMemOperand(scratch, Map::kInstanceTypeOffset));
3930 3930
3931 And(scratch, scratch, kStringRepresentationMask | kStringEncodingMask); 3931 And(scratch, scratch, kStringRepresentationMask | kStringEncodingMask);
3932 Cmp(scratch, encoding_mask); 3932 Cmp(scratch, encoding_mask);
3933 Check(eq, kUnexpectedStringType); 3933 Check(eq, kUnexpectedStringType);
3934 3934
3935 Ldr(scratch, FieldMemOperand(string, String::kLengthOffset)); 3935 Ldr(scratch, FieldMemOperand(string, String::kLengthOffset));
3936 Cmp(index, index_type == kIndexIsSmi ? scratch : Operand::UntagSmi(scratch)); 3936 Cmp(index, index_type == kIndexIsSmi ? scratch : Operand::UntagSmi(scratch));
3937 Check(lt, kIndexIsTooLarge); 3937 Check(lt, kIndexIsTooLarge);
3938 3938
3939 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0)); 3939 DCHECK_EQ(0, Smi::FromInt(0));
3940 Cmp(index, 0); 3940 Cmp(index, 0);
3941 Check(ge, kIndexIsNegative); 3941 Check(ge, kIndexIsNegative);
3942 } 3942 }
3943 3943
3944 3944
3945 void MacroAssembler::CheckAccessGlobalProxy(Register holder_reg, 3945 void MacroAssembler::CheckAccessGlobalProxy(Register holder_reg,
3946 Register scratch1, 3946 Register scratch1,
3947 Register scratch2, 3947 Register scratch2,
3948 Label* miss) { 3948 Label* miss) {
3949 DCHECK(!AreAliased(holder_reg, scratch1, scratch2)); 3949 DCHECK(!AreAliased(holder_reg, scratch1, scratch2));
(...skipping 1306 matching lines...) Expand 10 before | Expand all | Expand 10 after
5256 } 5256 }
5257 } 5257 }
5258 5258
5259 5259
5260 #undef __ 5260 #undef __
5261 5261
5262 5262
5263 } } // namespace v8::internal 5263 } } // namespace v8::internal
5264 5264
5265 #endif // V8_TARGET_ARCH_ARM64 5265 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/base/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698