Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: sky/engine/platform/EventTracer.cpp

Issue 893503002: Remove unused trace sampling states (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/EventTracer.h ('k') | sky/engine/platform/testing/RunAllTests.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/EventTracer.cpp
diff --git a/sky/engine/platform/EventTracer.cpp b/sky/engine/platform/EventTracer.cpp
index ea202f060e8b20238658fbb28cb58b6bcca7a9b5..45438c727f62e05275ed536b7d50b6f80a4b52c5 100644
--- a/sky/engine/platform/EventTracer.cpp
+++ b/sky/engine/platform/EventTracer.cpp
@@ -40,29 +40,6 @@ namespace blink {
COMPILE_ASSERT(sizeof(blink::Platform::TraceEventHandle) == sizeof(TraceEvent::TraceEventHandle), TraceEventHandle_types_must_be_compatible);
-// The dummy variable is needed to avoid a crash when someone updates the state variables
-// before EventTracer::initialize() is called.
-long dummyTraceSamplingState = 0;
-long* traceSamplingState[3] = {&dummyTraceSamplingState, &dummyTraceSamplingState, &dummyTraceSamplingState };
-
-void EventTracer::initialize()
-{
- // current() might not exist in unit tests.
- if (!blink::Platform::current())
- return;
-
- traceSamplingState[0] = blink::Platform::current()->getTraceSamplingState(0);
- // FIXME: traceSamplingState[0] can be 0 in split-dll build. http://crbug.com/256965
- if (!traceSamplingState[0])
- traceSamplingState[0] = &dummyTraceSamplingState;
- traceSamplingState[1] = blink::Platform::current()->getTraceSamplingState(1);
- if (!traceSamplingState[1])
- traceSamplingState[1] = &dummyTraceSamplingState;
- traceSamplingState[2] = blink::Platform::current()->getTraceSamplingState(2);
- if (!traceSamplingState[2])
- traceSamplingState[2] = &dummyTraceSamplingState;
-}
-
const unsigned char* EventTracer::getTraceCategoryEnabledFlag(const char* categoryName)
{
static const char* dummyCategoryEnabledFlag = "*";
« no previous file with comments | « sky/engine/platform/EventTracer.h ('k') | sky/engine/platform/testing/RunAllTests.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698