Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 893443002: Publish documentScan API documentation (Closed)

Created:
5 years, 10 months ago by Paul Stewart
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Publish documentScan API documentation This should just make the docs available for convenient referece by devs using the API. It need not be listed in any index. BUG=none R=kalman@chromium.org Committed: https://crrev.com/2c7050c2f50a4bc9180981252646e7dccea1f058 Cr-Commit-Position: refs/heads/master@{#313835}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added link to intros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
A chrome/common/extensions/docs/templates/intros/documentScan.html View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/extensions/documentScan.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Paul Stewart
5 years, 10 months ago (2015-01-29 23:23:34 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/893443002/diff/1/chrome/common/extensions/docs/templates/public/extensions/documentScan.html File chrome/common/extensions/docs/templates/public/extensions/documentScan.html (right): https://codereview.chromium.org/893443002/diff/1/chrome/common/extensions/docs/templates/public/extensions/documentScan.html#newcode1 chrome/common/extensions/docs/templates/public/extensions/documentScan.html:1: {{+partials.standard_extensions_api api:apis.extensions.document_scan/}} you also need to link to ...
5 years, 10 months ago (2015-01-29 23:36:34 UTC) #2
Paul Stewart
Thanks! https://codereview.chromium.org/893443002/diff/1/chrome/common/extensions/docs/templates/public/extensions/documentScan.html File chrome/common/extensions/docs/templates/public/extensions/documentScan.html (right): https://codereview.chromium.org/893443002/diff/1/chrome/common/extensions/docs/templates/public/extensions/documentScan.html#newcode1 chrome/common/extensions/docs/templates/public/extensions/documentScan.html:1: {{+partials.standard_extensions_api api:apis.extensions.document_scan/}} On 2015/01/29 23:36:34, kalman wrote: > ...
5 years, 10 months ago (2015-01-29 23:46:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893443002/20001
5 years, 10 months ago (2015-01-29 23:47:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 00:21:54 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 00:23:39 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2c7050c2f50a4bc9180981252646e7dccea1f058
Cr-Commit-Position: refs/heads/master@{#313835}

Powered by Google App Engine
This is Rietveld 408576698