Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: net/http/http_server_properties_manager_unittest.cc

Issue 893403005: Add HttpServerPropertiesManagerTest.UpdateCacheWithPrefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use JSON. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_manager_unittest.cc
diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc
index 6443d4b1a50ec755de49e83bc0661b5443e96cc8..f2e36499e736850c19b757f9e8146e5d6adbf96c 100644
--- a/net/http/http_server_properties_manager_unittest.cc
+++ b/net/http/http_server_properties_manager_unittest.cc
@@ -5,6 +5,7 @@
#include "net/http/http_server_properties_manager.h"
#include "base/basictypes.h"
+#include "base/json/json_writer.h"
#include "base/message_loop/message_loop.h"
#include "base/prefs/pref_registry_simple.h"
#include "base/prefs/testing_pref_service.h"
@@ -645,6 +646,64 @@ TEST_F(HttpServerPropertiesManagerTest, BadSupportsQuic) {
EXPECT_EQ("127.0.0.1", IPAddressToString(address));
}
+TEST_F(HttpServerPropertiesManagerTest, UpdateCacheWithPrefs) {
+ const HostPortPair server_www("www.google.com", 80);
+ const HostPortPair server_mail("mail.google.com", 80);
+
+ // Set alternate protocol.
+ http_server_props_manager_->SetAlternateProtocol(server_www, 443, NPN_SPDY_3,
+ 1.0);
+ http_server_props_manager_->SetAlternateProtocol(server_mail, 444,
+ NPN_SPDY_3_1, 0.2);
+
+ // Set ServerNetworkStats.
+ ServerNetworkStats stats;
+ stats.srtt = base::TimeDelta::FromInternalValue(42);
+ http_server_props_manager_->SetServerNetworkStats(server_mail, stats);
+
+ // Set SupportsQuic.
+ IPAddressNumber actual_address;
+ CHECK(ParseIPLiteralToNumber("127.0.0.1", &actual_address));
+ http_server_props_manager_->SetSupportsQuic(true, actual_address);
+
+ // Update cache.
+ ExpectPrefsUpdate();
+ ExpectCacheUpdate();
+ http_server_props_manager_->ScheduleUpdateCacheOnPrefThread();
+ base::RunLoop().RunUntilIdle();
+
+ // Verify preferences.
+ const char expected_json[] = "{"
+ "\"servers\":{"
Bence 2015/02/05 14:53:24 This indentation is easier to read, but it is not
Ryan Hamilton 2015/02/05 15:29:13 Either way is fine with me. Your call.
+ "\"mail.google.com:80\":{"
+ "\"alternate_protocol\":{"
+ "\"port\":444,\"probability\":0.2,\"protocol_str\":\"npn-spdy/3.1\""
+ "},"
+ "\"network_stats\":{"
+ "\"srtt\":42"
+ "}"
+ "},"
+ "\"www.google.com:80\":{"
+ "\"alternate_protocol\":{"
+ "\"port\":443,\"probability\":1.0,\"protocol_str\":\"npn-spdy/3\""
+ "}"
+ "}"
+ "},"
+ "\"supports_quic\":{"
+ "\"address\":\"127.0.0.1\",\"used_quic\":true"
+ "},"
+ "\"version\":3"
+ "}";
+
+ const base::Value* http_server_properties =
+ pref_service_.GetUserPref(kTestHttpServerProperties);
+ ASSERT_NE(nullptr, http_server_properties);
+ std::string preferences_json;
+ EXPECT_TRUE(
+ base::JSONWriter::Write(http_server_properties, &preferences_json));
+ EXPECT_EQ(expected_json, preferences_json);
+}
+
TEST_F(HttpServerPropertiesManagerTest, ShutdownWithPendingUpdateCache0) {
// Post an update task to the UI thread.
http_server_props_manager_->ScheduleUpdateCacheOnPrefThread();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698