Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 893403004: webui: make 0 into 0ms when it's a <time>. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, vsevik, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, estade+watch_chromium.org, aboxhall+watch_chromium.org, yurys, yuzo+watch_chromium.org, rginda+watch_chromium.org, paulirish+reviews_chromium.org, arv+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, mtomasz+watch_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webui: make 0 into 0ms when it's a <time>. R=arv@chromium.org TBR=sky@chromium.org BUG=454776 Committed: https://crrev.com/78f64bb730284ea195de88aec389453e792b9fb7 Cr-Commit-Position: refs/heads/master@{#314643}

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M chrome/browser/devtools/frontend/devtools_discovery_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth/offline.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/apps_page.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/set_as_default_browser.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/css/chrome_shared.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/css/overlay.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/third_party/chromevox/chromevox/background/chrome_shared2.css View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/drive_welcome.css View 2 chunks +2 lines, -2 lines 2 comments Download
M ui/file_manager/gallery/css/gallery.css View 4 chunks +5 lines, -5 lines 5 comments Download
M ui/webui/resources/css/chrome_shared.css View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/css/overlay.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Dan Beam
https://codereview.chromium.org/893403004/diff/1/ui/file_manager/file_manager/foreground/css/drive_welcome.css File ui/file_manager/file_manager/foreground/css/drive_welcome.css (left): https://codereview.chromium.org/893403004/diff/1/ui/file_manager/file_manager/foreground/css/drive_welcome.css#oldcode77 ui/file_manager/file_manager/foreground/css/drive_welcome.css:77: transition: height 180ms ease, visibility 0 linear 180ms; unsure ...
5 years, 10 months ago (2015-02-04 18:09:27 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/893403004/diff/1/ui/file_manager/file_manager/foreground/css/drive_welcome.css File ui/file_manager/file_manager/foreground/css/drive_welcome.css (left): https://codereview.chromium.org/893403004/diff/1/ui/file_manager/file_manager/foreground/css/drive_welcome.css#oldcode77 ui/file_manager/file_manager/foreground/css/drive_welcome.css:77: transition: height 180ms ease, visibility 0 linear 180ms; ...
5 years, 10 months ago (2015-02-04 20:37:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893403004/1
5 years, 10 months ago (2015-02-04 20:53:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40471)
5 years, 10 months ago (2015-02-04 21:00:24 UTC) #6
Dan Beam
TBR=sky
5 years, 10 months ago (2015-02-04 21:01:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893403004/1
5 years, 10 months ago (2015-02-04 21:02:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 21:43:58 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:44:51 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/78f64bb730284ea195de88aec389453e792b9fb7
Cr-Commit-Position: refs/heads/master@{#314643}

Powered by Google App Engine
This is Rietveld 408576698