win: Locally disable allocation alignment warning

win: Locally disable allocation alignment warning

A (somewhat cursory) inspection leads me to believe that there's
no particular alignment requirements for this object at this location,
so this warning can be ignored.

d:\src\crashpad\crashpad\minidump\minidump_context_writer.cc(43) : error C2220: warning treated as error - no 'object' file generated
d:\src\crashpad\crashpad\minidump\minidump_context_writer.cc(43) : warning C4316: 'crashpad::MinidumpContextAMD64Writer' : object allocated on the heap may not be aligned 16

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/2b46aaabda6c4f38bce600d388b878cfd1212ab0

[Mark Mentovai, 2015-02-04 21:39:43]

LGTM. I believe that this is fine too.

I’m a little surprised to see the warning. Did this happen in a 32-bit build or
in both 32-bit and 64-bit builds?

[scottmg, 2015-02-04 21:49:02]

On 2015/02/04 21:39:43, Mark Mentovai wrote:
> LGTM. I believe that this is fine too.
> 
> I’m a little surprised to see the warning. Did this happen in a 32-bit build
or
> in both 32-bit and 64-bit builds?

I've only tried building 32 so far. I don't think it would trigger on 64 because
the allocator guarantees 16 aligned on 64.

(It only happens on the AMD64 structure though of course, because the x86 one
isn't marked align.)

[Mark Mentovai, 2015-02-04 22:25:34]

OK, that ought to be fine. Can you limit the warning-disabling to 32-bit x86
with && defined(ARCH_CPU_X86) then?

[scottmg, 2015-02-05 01:36:24]

New patchsets have been uploaded after l-g-t-m from mark@chromium.org

[scottmg, 2015-02-05 01:36:42]

Committed patchset #3 (id:40001) manually as
2b46aaabda6c4f38bce600d388b878cfd1212ab0 (presubmit successful).

[scottmg, 2015-02-05 01:36:48]

On 2015/02/04 22:25:34, Mark Mentovai wrote:
> OK, that ought to be fine. Can you limit the warning-disabling to 32-bit x86
> with && defined(ARCH_CPU_X86) then?

Done.